airbnb/caravel

View on GitHub

Showing 2,441 of 6,157 total issues

File index.tsx has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/src/pages/AnnotationList/index.tsx - About 3 hrs to fix

    Function drawChart has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      drawChart() {
        if (this.canvas) {
          const {
            data: rawData,
            yDomain,

      Function dashboardFiltersReducer has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function dashboardFiltersReducer(dashboardFilters = {}, action) {
        const actionHandlers = {
          [CHANGE_FILTER](state) {
            const { newSelectedValues, merge } = action;
            const updatedColumns = Object.keys(newSelectedValues).reduce(
      Severity: Major
      Found in superset-frontend/src/dashboard/reducers/dashboardFilters.js - About 3 hrs to fix

        Function renderControls has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const renderControls = () => {
            if (search || visualize || csv) {
              let { data } = query.results;
              if (cache && query.cached) {
                data = cachedData;
        Severity: Major
        Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 3 hrs to fix

          File FilterValue.tsx has 300 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /**
           * Licensed to the Apache Software Foundation (ASF) under one
           * or more contributor license agreements.  See the NOTICE file
           * distributed with this work for additional information
           * regarding copyright ownership.  The ASF licenses this file

            AnnotationLayer has 27 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class AnnotationLayer extends PureComponent {
              constructor(props) {
                super(props);
                const {
                  name,

              Function transformProps has 79 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export default function transformProps(
                chartProps: SankeyChartProps,
              ): SankeyTransformedProps {
                const refs: Refs = {};
                const { formData, height, hooks, queriesData, width } = chartProps;

                Function DeckMulti has 79 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const DeckMulti = (props: DeckMultiProps) => {
                  const containerRef = useRef<DeckGLContainerHandle>();
                
                  const [viewport, setViewport] = useState<Viewport>();
                  const [subSlicesLayers, setSubSlicesLayers] = useState<Record<number, Layer>>(

                  Function renderChart has 79 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    renderChart(width: number, height: number) {
                      const {
                        id,
                        className,
                        chartType,

                    File PropertiesModal.test.jsx has 297 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /**
                     * Licensed to the Apache Software Foundation (ASF) under one
                     * or more contributor license agreements.  See the NOTICE file
                     * distributed with this work for additional information
                     * regarding copyright ownership.  The ASF licenses this file

                      File Select.stories.tsx has 296 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /**
                       * Licensed to the Apache Software Foundation (ASF) under one
                       * or more contributor license agreements.  See the NOTICE file
                       * distributed with this work for additional information
                       * regarding copyright ownership.  The ASF licenses this file
                      Severity: Minor
                      Found in superset-frontend/src/components/Select/Select.stories.tsx - About 3 hrs to fix

                        File PostProcessing.ts has 296 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /**
                         * Licensed to the Apache Software Foundation (ASF) under one
                         * or more contributor license agreements.  See the NOTICE file
                         * distributed with this work for additional information
                         * regarding copyright ownership.  The ASF licenses this file

                          Function add_sample_rows has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def add_sample_rows(model: type[Model], count: int) -> Iterator[Model]:
                              """
                              Add entities of a given model.
                          
                              :param Model model: a Superset/FAB model
                          Severity: Minor
                          Found in superset/utils/mock_data.py - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function merge_extra_form_data has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def merge_extra_form_data(form_data: dict[str, Any]) -> None:
                              """
                              Merge extra form data (appends and overrides) into the main payload
                              and add applied time extras to the payload.
                              """
                          Severity: Minor
                          Found in superset/utils/core.py - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function insert_rls_as_subquery has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def insert_rls_as_subquery(
                              token_list: TokenList,
                              database_id: int,
                              default_schema: str | None,
                          ) -> TokenList:
                          Severity: Minor
                          Found in superset/sql_parse.py - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function import_dashboard has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def import_dashboard(
                              config: dict[str, Any],
                              overwrite: bool = False,
                              ignore_permissions: bool = False,
                          ) -> Dashboard:
                          Severity: Minor
                          Found in superset/commands/dashboard/importers/v1/utils.py - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function _export has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def _export(
                                  model: Dashboard, export_related: bool = True
                              ) -> Iterator[tuple[str, Callable[[], str]]]:
                                  yield (
                                      ExportDashboardsCommand._file_name(model),
                          Severity: Minor
                          Found in superset/commands/dashboard/export.py - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function transformProps has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export default function transformProps(
                            chartProps: EchartsBoxPlotChartProps,
                          ): BoxPlotChartTransformedProps {
                            const {
                              width,

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function PropertiesModal has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function PropertiesModal({
                            slice,
                            onHide,
                            onSave,
                            show,
                          Severity: Minor
                          Found in superset-frontend/src/explore/components/PropertiesModal/index.tsx - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function formatValueHandler has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export const formatValueHandler = (
                            value: DiffItemType,
                            key: string,
                            controlsMap: ControlMap,
                          ): string | number => {
                          Severity: Minor
                          Found in superset-frontend/src/components/AlteredSliceTag/index.tsx - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language