airbnb/caravel

View on GitHub
superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts

Summary

Maintainability
F
4 days
Test Coverage

Function getTimeOffset has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

export const getTimeOffset = ({
  timeRangeFilter,
  shifts,
  startDate,
  includeFutureOffsets = true,

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseDttmToDate has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

export const parseDttmToDate = (
  dttm: string,
  isEndDate = false,
  computingShifts = false,
) => {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseDttmToDate has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const parseDttmToDate = (
  dttm: string,
  isEndDate = false,
  computingShifts = false,
) => {

    File getTimeOffset.ts has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * Licensed to the Apache Software Foundation (ASF) under one
     * or more contributor license agreements.  See the NOTICE file
     * distributed with this work for additional information
     * regarding copyright ownership.  The ASF licenses this file

      Function computeCustomDateTime has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const computeCustomDateTime = (
        dttm: string,
        grain: string,
        grainValue: number,
      ) => {

        Avoid too many return statements within this function.
        Open

              return now;

          Avoid too many return statements within this function.
          Open

                return now;

            Avoid too many return statements within this function.
            Open

                  return shift;

              Avoid too many return statements within this function.
              Open

                  return parsed;

                Avoid too many return statements within this function.
                Open

                    return now;

                  Avoid too many return statements within this function.
                  Open

                        return now;

                    Avoid too many return statements within this function.
                    Open

                          return now;

                      Avoid too many return statements within this function.
                      Open

                            return now;

                        Avoid too many return statements within this function.
                        Open

                          return null;

                          Avoid too many return statements within this function.
                          Open

                                return now;

                            Avoid too many return statements within this function.
                            Open

                                  return now;

                              Function computeCustomDateTime has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export const computeCustomDateTime = (
                                dttm: string,
                                grain: string,
                                grainValue: number,
                              ) => {

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  if (sinceMode !== 'relative') {
                                    if (sinceMode === 'specific') {
                                      customStartDate = new Date(sinceDatetime);
                                    } else {
                                      customStartDate = parseDttmToDate(sinceDatetime, false, true);
                              superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 239..251
                              superset-frontend/src/explore/components/controls/TimeOffsetControl.tsx on lines 111..123

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 67.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  if (untilMode !== 'relative') {
                                    if (untilMode === 'specific') {
                                      customEndDate = new Date(untilDatetime);
                                    } else {
                                      customEndDate = parseDttmToDate(untilDatetime, false, true);
                              superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 225..237
                              superset-frontend/src/explore/components/controls/TimeOffsetControl.tsx on lines 111..123

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 67.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                if (computingShifts) {
                                  now.setHours(-now.getTimezoneOffset() / 60, 0, 0, 0);
                                } else {
                                  now.setHours(0, 0, 0, 0);
                                }
                              superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 139..143

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 52.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  if (computingShifts) {
                                    parsed.setHours(-parsed.getTimezoneOffset() / 60, 0, 0, 0);
                                  } else {
                                    parsed.setHours(0, 0, 0, 0);
                                  }
                              superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 40..44

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 52.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status