Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx

Summary

Maintainability
D
1 day
Test Coverage

File controlPanel.tsx has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  description: (
                <>
                  <div>
                    {t(
                      'Color will be shaded based the normalized (0% to 100%) value of a given cell against the other cells in the selected range: ',
    Severity: Major
    Found in superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx and 1 other location - About 3 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 84..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'left_margin',
            config: {
              type: 'SelectControl',
    Severity: Major
    Found in superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx and 3 other locations - About 3 hrs to fix
    superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx on lines 185..209
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 164..188
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 189..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'bottom_margin',
            config: {
              type: 'SelectControl',
    Severity: Major
    Found in superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx and 3 other locations - About 3 hrs to fix
    superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx on lines 160..184
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 164..188
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 189..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            [
          {
            name: 'show_perc',
            config: {
              type: 'CheckboxControl',
    Severity: Major
    Found in superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx and 6 other locations - About 40 mins to fix
    superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx on lines 301..314
    superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts on lines 120..131
    superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts on lines 132..143
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 241..254
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 269..282
    superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx on lines 251..262

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            [
          {
            name: 'normalized',
            config: {
              type: 'CheckboxControl',
    Severity: Major
    Found in superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx and 6 other locations - About 40 mins to fix
    superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx on lines 273..286
    superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts on lines 120..131
    superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts on lines 132..143
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 241..254
    superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx on lines 269..282
    superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx on lines 251..262

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status