Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx

Summary

Maintainability
D
2 days
Test Coverage

File controlPanel.tsx has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx - About 3 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'repulsion',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 3 other locations - About 3 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 235..255
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 256..276
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 298..318

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'friction',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 3 other locations - About 3 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 235..255
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 256..276
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 277..297

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'edgeLength',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 3 other locations - About 3 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 256..276
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 277..297
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 298..318

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'gravity',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 3 other locations - About 3 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 235..255
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 277..297
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 298..318

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              {
            name: 'baseEdgeWidth',
            config: {
              type: 'TextControl',
              label: t('Edge width'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 193..205
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 208..220

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              {
            name: 'showSymbolThreshold',
            config: {
              type: 'TextControl',
              label: t('Label threshold'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 208..220
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 221..233

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              {
            name: 'baseNodeSize',
            config: {
              type: 'TextControl',
              label: t('Node size'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 193..205
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx on lines 221..233

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status