Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx

Summary

Maintainability
F
3 days
Test Coverage

File controlPanel.tsx has 450 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx - About 6 hrs to fix

    Function createCustomizeSection has 126 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function createCustomizeSection(
  label: string,
  controlSuffix: string,
): ControlSetRow[] {
  return [
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx - About 5 hrs to fix

      Function createQuerySection has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createQuerySection(
  label: string,
  controlSuffix: string,
): ControlPanelSectionConfig {
  return {
      Severity: Major
      Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                config: {
          type: 'SelectControl',
          label: t('Series type'),
          renderTrigger: true,
          default: seriesType,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 1 other location - About 4 hrs to fix
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx on lines 76..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const {
  area,
  logAxis,
  markerEnabled,
  markerSize,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 1 other location - About 2 hrs to fix
        superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.tsx on lines 149..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            [
      {
        name: `markerEnabled${controlSuffix}`,
        config: {
          type: 'CheckboxControl',
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 3 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 160..171
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 172..185
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 186..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            [
      {
        name: `stack${controlSuffix}`,
        config: {
          type: 'CheckboxControl',
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 3 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 172..185
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 186..199
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 215..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            [
      {
        name: `area${controlSuffix}`,
        config: {
          type: 'CheckboxControl',
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 3 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 160..171
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 186..199
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 215..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            [
      {
        name: `show_value${controlSuffix}`,
        config: {
          type: 'CheckboxControl',
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 3 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 160..171
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 172..185
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx on lines 215..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                [
          {
            name: 'yAxisTitleSecondary',
            config: {
              type: 'TextControl',
        Severity: Minor
        Found in superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx and 2 other locations - About 40 mins to fix
        superset-frontend/packages/superset-ui-chart-controls/src/sections/chartTitle.tsx on lines 39..50
        superset-frontend/packages/superset-ui-chart-controls/src/sections/chartTitle.tsx on lines 67..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status