Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx

Summary

Maintainability
D
1 day
Test Coverage

File controlPanel.tsx has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            [
          {
            name: 'innerRadius',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 2 other locations - About 3 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx on lines 109..127
    superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx on lines 103..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            [
          {
            name: 'label_line',
            config: {
              type: 'CheckboxControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 1 other location - About 2 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx on lines 190..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            [
          {
            name: 'labels_outside',
            config: {
              type: 'CheckboxControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 1 other location - About 2 hrs to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx on lines 204..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            [
          {
            name: 'outerRadius',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Bubble/controlPanel.tsx on lines 101..117
    superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx on lines 91..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            [
          {
            name: 'date_format',
            config: {
              type: 'SelectControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 3 other locations - About 55 mins to fix
    superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts on lines 144..157
    superset-frontend/plugins/plugin-chart-echarts/src/Radar/controlPanel.tsx on lines 159..172
    superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx on lines 126..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    const {
  donut,
  innerRadius,
  labelsOutside,
  labelType,
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 7 other locations - About 55 mins to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts on lines 89..99
    superset-frontend/plugins/plugin-chart-echarts/src/Gauge/transformProps.ts on lines 98..108
    superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts on lines 159..169
    superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts on lines 75..85
    superset-frontend/src/dashboard/components/PropertiesModal/index.tsx on lines 167..177
    superset-frontend/src/filters/components/Range/transformProps.ts on lines 23..33
    superset-frontend/src/filters/components/Time/transformProps.ts on lines 24..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            [
          {
            name: 'show_labels_threshold',
            config: {
              type: 'TextControl',
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx and 1 other location - About 55 mins to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx on lines 67..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status