Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx

Summary

Maintainability
C
7 hrs
Test Coverage

File controlPanel.tsx has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            [
          {
            name: 'opacity',
            config: {
              type: 'SliderControl',
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Bubble/controlPanel.tsx on lines 101..117
    superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx on lines 234..248

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  choices: [
                [EchartsTimeseriesSeriesType.Line, t('Line')],
                [EchartsTimeseriesSeriesType.Smooth, t('Smooth Line')],
                [EchartsTimeseriesSeriesType.Start, t('Step - start')],
                [EchartsTimeseriesSeriesType.Middle, t('Step - middle')],
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx and 1 other location - About 1 hr to fix
    superset-frontend/packages/superset-ui-chart-controls/src/constants.ts on lines 69..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

    const {
  logAxis,
  markerEnabled,
  markerSize,
  minorSplitLine,
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx and 6 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts on lines 78..89
    superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts on lines 120..131
    superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 123..134
    superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts on lines 161..172
    superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx on lines 43..54
    superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts on lines 111..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              {
            name: 'show_extra_controls',
            config: {
              type: 'CheckboxControl',
              label: t('Extra Controls'),
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx and 1 other location - About 55 mins to fix
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 163..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              {
            name: 'stack',
            config: {
              type: 'SelectControl',
              label: t('Stacked Style'),
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx and 1 other location - About 50 mins to fix
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 118..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status