Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts

Summary

Maintainability
F
5 days
Test Coverage

File transformers.ts has 549 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Major
Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 1 day to fix

    Function transformSeries has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

    export function transformSeries(
  series: SeriesOption,
  colorScale: CategoricalColorScale,
  colorScaleKey: string,
  opts: {
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function transformSeries has 151 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function transformSeries(
  series: SeriesOption,
  colorScale: CategoricalColorScale,
  colorScaleKey: string,
  opts: {
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 6 hrs to fix

      Function transformIntervalAnnotation has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function transformIntervalAnnotation(
  layer: IntervalAnnotationLayer,
  data: TimeseriesDataRecord[],
  annotationData: AnnotationData,
  colorScale: CategoricalColorScale,
      Severity: Major
      Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 2 hrs to fix

        Function getBaselineSeriesForStream has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        export const getBaselineSeriesForStream = (
  series: [string | number, number][][],
  seriesType: EchartsTimeseriesSeriesType,
) => {
  const seriesLength = series[0].length;
        Severity: Minor
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getBaselineSeriesForStream has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const getBaselineSeriesForStream = (
  series: [string | number, number][][],
  seriesType: EchartsTimeseriesSeriesType,
) => {
  const seriesLength = series[0].length;
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 2 hrs to fix

          Function transformEventAnnotation has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function transformEventAnnotation(
  layer: EventAnnotationLayer,
  data: TimeseriesDataRecord[],
  annotationData: AnnotationData,
  colorScale: CategoricalColorScale,
          Severity: Major
          Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 2 hrs to fix

            Function getPadding has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function getPadding(
  showLegend: boolean,
  legendOrientation: LegendOrientation,
  addYAxisTitleOffset: boolean,
  zoomable: boolean,
            Severity: Minor
            Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 1 hr to fix

              Function getPadding has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              export function getPadding(
  showLegend: boolean,
  legendOrientation: LegendOrientation,
  addYAxisTitleOffset: boolean,
  zoomable: boolean,
              Severity: Minor
              Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getPadding has 10 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                showLegend: boolean,
  legendOrientation: LegendOrientation,
  addYAxisTitleOffset: boolean,
  zoomable: boolean,
  margin?: string | number | null,
              Severity: Major
              Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 1 hr to fix

                Function transformFormulaAnnotation has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  layer: FormulaAnnotationLayer,
  data: TimeseriesDataRecord[],
  xAxisCol: string,
  xAxisType: AxisType,
  colorScale: CategoricalColorScale,
                Severity: Minor
                Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 45 mins to fix

                  Function transformEventAnnotation has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    layer: EventAnnotationLayer,
  data: TimeseriesDataRecord[],
  annotationData: AnnotationData,
  colorScale: CategoricalColorScale,
  theme: SupersetTheme,
                  Severity: Minor
                  Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 45 mins to fix

                    Function transformIntervalAnnotation has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      layer: IntervalAnnotationLayer,
  data: TimeseriesDataRecord[],
  annotationData: AnnotationData,
  colorScale: CategoricalColorScale,
  theme: SupersetTheme,
                    Severity: Minor
                    Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 45 mins to fix

                      Function transformTimeseriesAnnotation has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        layer: TimeseriesAnnotationLayer,
  markerSize: number,
  data: TimeseriesDataRecord[],
  annotationData: AnnotationData,
  colorScale: CategoricalColorScale,
                      Severity: Minor
                      Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 45 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                  return formatter(isAreaExpand ? 1 : totalStackedValues[dataIndex]);
                        Severity: Major
                        Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return '';
                          Severity: Major
                          Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    i > 0
          ? getVal(series[j][i][1]) - getVal(series[j][i - 1][1])
          : getVal(series[j][i][1]);
                            Severity: Major
                            Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts and 1 other location - About 1 hr to fix
                            superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts on lines 92..94

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                      i > 0
            ? getVal(series[k][i][1]) - getVal(series[k][i - 1][1])
            : getVal(series[k][i][1]);
                            Severity: Major
                            Found in superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts and 1 other location - About 1 hr to fix
                            superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts on lines 86..88

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status