Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx

Summary

Maintainability
C
1 day
Test Coverage

File controls.tsx has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const sortSeriesAscending: ControlSetItem = {
  name: 'sort_series_ascending',
  config: {
    type: 'CheckboxControl',
    label: t('Sort Series Ascending'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx and 1 other location - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 270..281

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export const truncateXAxis: ControlSetItem = {
  name: 'truncateXAxis',
  config: {
    type: 'CheckboxControl',
    label: t('Truncate X Axis'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx and 1 other location - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 235..244

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    export const showValueControl: ControlSetItem = {
  name: 'show_value',
  config: {
    type: 'CheckboxControl',
    label: t('Show Value'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx and 10 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 301..310
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 312..321
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 59..68
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 94..103
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 105..114
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 152..161
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 243..252
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 286..295
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 297..308
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 310..319

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    export const forceCategorical: ControlSetItem = {
  name: 'forceCategorical',
  config: {
    type: 'CheckboxControl',
    label: t('Force categorical'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx and 10 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 107..116
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 301..310
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 59..68
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 94..103
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 105..114
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 152..161
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 243..252
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 286..295
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 297..308
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 310..319

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    export const minorTicks: ControlSetItem = {
  name: 'minorTicks',
  config: {
    type: 'CheckboxControl',
    label: t('Minor ticks'),
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx and 10 other locations - About 1 hr to fix
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 107..116
    superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx on lines 312..321
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 59..68
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 94..103
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 105..114
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 152..161
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 243..252
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 286..295
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 297..308
    superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx on lines 310..319

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export const stackControl: ControlSetItem = {
  name: 'stack',
  config: {
    type: 'SelectControl',
    label: t('Stacked Style'),
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx and 1 other location - About 50 mins to fix
    superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx on lines 109..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status