Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Function TableChart has a Cognitive Complexity of 124 (exceeds 5 allowed). Consider refactoring.
Open

export default function TableChart<D extends DataRecord = DataRecord>(
  props: TableChartTransformedProps<D> & {
    sticky?: DataTableProps<D>['sticky'];
  },
) {
Severity: Minor
Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TableChart has 481 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function TableChart<D extends DataRecord = DataRecord>(
  props: TableChartTransformedProps<D> & {
    sticky?: DataTableProps<D>['sticky'];
  },
) {
Severity: Major
Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 2 days to fix

    File TableChart.tsx has 654 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Major
    Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 1 day to fix

      Function getColumnConfigs has 214 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (column: DataColumnMeta, i: number): ColumnWithLooseAccessor<D> => {
      const {
        key,
        label,
        isNumeric,
      Severity: Major
      Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 1 day to fix

        Function getCrossFilterDataMask has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const getCrossFilterDataMask = (key: string, value: DataRecordValue) => {
    let updatedFilters = { ...(filters || {}) };
    if (filters && isActiveFilterValue(key, value)) {
      updatedFilters = {};
    } else {
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 2 hrs to fix

          Function handleContextMenu has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                ? (
          value: D,
          cellPoint: {
            key: string;
            value: DataRecordValue;
          Severity: Minor
          Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function SelectPageSize({
  options,
  current,
  onChange,
}: SelectPageSizeRendererProps) {
            Severity: Major
            Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx and 1 other location - About 1 day to fix
            superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SelectPageSize.tsx on lines 31..61

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 224.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function cellWidth({
  value,
  valueRange,
  alignPositiveNegative,
}: {
            Severity: Minor
            Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx and 1 other location - About 35 mins to fix
            superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx on lines 121..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function cellOffset({
  value,
  valueRange,
  alignPositiveNegative,
}: {
            Severity: Minor
            Found in superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx and 1 other location - About 35 mins to fix
            superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx on lines 96..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status