airbnb/caravel

View on GitHub
superset-frontend/src/SqlLab/components/QueryTable/index.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function data has 195 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const data = useMemo(() => {
    const restoreSql = (query: QueryResponse) => {
      dispatch(
        queryEditorSetSql({ id: query.sqlEditorId }, query.sql, query.id),
      );
Severity: Major
Found in superset-frontend/src/SqlLab/components/QueryTable/index.tsx - About 7 hrs to fix

    File index.tsx has 290 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * Licensed to the Apache Software Foundation (ASF) under one
     * or more contributor license agreements.  See the NOTICE file
     * distributed with this work for additional information
     * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/src/SqlLab/components/QueryTable/index.tsx - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              q.user = (
                <Button
                  buttonSize="small"
                  buttonStyle="link"
                  onClick={() => onUserClicked(q.userId)}
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 209..217

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              q.db = (
                <Button
                  buttonSize="small"
                  buttonStyle="link"
                  onClick={() => onDbClicked(q.dbId)}
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 200..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            failed: {
              config: {
                icon: <Icons.XSmall iconColor={theme.colors.error.base} />,
                label: t('Failed'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            pending: {
              config: {
                icon: <Icons.Queued iconColor={theme.colors.grayscale.base} />,
                label: t('Scheduled'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            running: {
              config: {
                icon: <Icons.Running iconColor={theme.colors.primary.base} />,
                label: t('Running'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            success: {
              config: {
                icon: <Icons.Check iconColor={theme.colors.success.base} />,
                label: t('Success'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            scheduled: {
              config: {
                icon: <Icons.Queued iconColor={theme.colors.grayscale.base} />,
                label: t('Scheduled'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            error: {
              config: {
                icon: <Icons.Error iconColor={theme.colors.error.base} />,
                label: t('Unknown Status'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            fetching: {
              config: {
                icon: <Icons.Queued iconColor={theme.colors.primary.base} />,
                label: t('Fetching'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            timed_out: {
              config: {
                icon: <Icons.Offline iconColor={theme.colors.grayscale.light1} />,
                label: t('Offline'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 138..143
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            stopped: {
              config: {
                icon: <Icons.XSmall iconColor={theme.colors.error.base} />,
                label: t('Failed'),
              },
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 126..131
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 132..137
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 144..149
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 150..155
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 156..161
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 162..167
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 168..173
      superset-frontend/src/SqlLab/components/QueryTable/index.tsx on lines 174..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status