Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx

Summary

Maintainability
C
1 day
Test Coverage

File index.tsx has 384 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx - About 5 hrs to fix

    Function SaveDatasetModal has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    export const SaveDatasetModal = ({
  visible,
  onHide,
  buttonTextOnSave,
  buttonTextOnOverwrite,
    Severity: Minor
    Found in superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleSaveInDataset has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const handleSaveInDataset = () => {
    setLoading(true);
    const selectedColumns = datasource?.columns ?? [];

    // The filters param is only used to test jinja templates.
    Severity: Minor
    Found in superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx - About 1 hr to fix

      Function handleOverwriteDataset has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const handleOverwriteDataset = async () => {
    // if user wants to overwrite a dataset we need to prompt them
    if (!shouldOverwriteDataset) {
      setShouldOverwriteDataset(true);
      return;
      Severity: Minor
      Found in superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx - About 1 hr to fix

        Function loadDatasetOverwriteOptions has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async (input = '') => {
      const { userId } = user;
      const queryParams = rison.encode({
        filters: [
          {
        Severity: Minor
        Found in superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status