Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/SqlLab/reducers/getInitialState.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function getInitialState has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

export default function getInitialState({
  common,
  active_tab: activeTab,
  tab_state_ids: tabStateIds = [],
  databases,
Severity: Minor
Found in superset-frontend/src/SqlLab/reducers/getInitialState.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

      if (sqlLab.queryEditors.length === 0) {
        // migration was successful
        localStorage.removeItem('redux');
      } else {
        unsavedQueryEditor = sqlLab.unsavedQueryEditor || unsavedQueryEditor;
Severity: Critical
Found in superset-frontend/src/SqlLab/reducers/getInitialState.ts - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (activeTab && activeTab.id === id) {
      queryEditor = {
        version: activeTab.extra_json?.version ?? QueryEditorVersion.V1,
        id: id.toString(),
        loaded: true,
    Severity: Major
    Found in superset-frontend/src/SqlLab/reducers/getInitialState.ts - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status