Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/components/Chart/Chart.tsx

Summary

Maintainability
C
1 day
Test Coverage

File Chart.tsx has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/src/components/Chart/Chart.tsx - About 4 hrs to fix

    Function render has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    const {
      height,
      chartAlert,
      chartStatus,
    Severity: Major
    Found in superset-frontend/src/components/Chart/Chart.tsx - About 2 hrs to fix

      Function renderErrorMessage has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        renderErrorMessage(queryResponse: ChartErrorType) {
    const {
      chartId,
      chartAlert,
      chartStackTrace,
      Severity: Minor
      Found in superset-frontend/src/components/Chart/Chart.tsx - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        const MessageSpan = styled.span`
  display: block;
  text-align: center;
  margin: ${({ theme }) => theme.gridUnit * 4}px auto;
  width: fit-content;
        Severity: Major
        Found in superset-frontend/src/components/Chart/Chart.tsx and 2 other locations - About 1 hr to fix
        superset-frontend/src/components/ListView/ListView.tsx on lines 164..170
        superset-frontend/src/explore/components/controls/OptionControls/index.tsx on lines 84..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const {
      chartId,
      chartAlert,
      chartStackTrace,
      datasource,
        Severity: Minor
        Found in superset-frontend/src/components/Chart/Chart.tsx and 1 other location - About 35 mins to fix
        superset-frontend/packages/superset-ui-core/src/chart-composition/legend/WithLegend.tsx on lines 88..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          constructor(props: ChartProps) {
    super(props);
    this.handleRenderContainerFailure =
      this.handleRenderContainerFailure.bind(this);
  }
        Severity: Major
        Found in superset-frontend/src/components/Chart/Chart.tsx and 3 other locations - About 30 mins to fix
        superset-frontend/src/components/Datasource/Fieldset.tsx on lines 41..44
        superset-frontend/src/dashboard/components/PublishedStatus/index.tsx on lines 48..51
        superset-frontend/src/dashboard/components/UndoRedoKeyListeners/index.tsx on lines 28..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status