Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/components/Chart/ChartRenderer.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { chartAlert, chartStatus, chartId, emitCrossFilters } = this.props;

    // Skip chart rendering
    if (chartStatus === 'loading' || !!chartAlert || chartStatus === null) {
Severity: Major
Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (resultsReady) {
      if (!isEqual(this.state, nextState)) {
        return true;
      }
      this.hasQueryResponseChange =
    Severity: Critical
    Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 3 hrs to fix

      File ChartRenderer.jsx has 305 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
      Severity: Minor
      Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 3 hrs to fix

        Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(props) {
    super(props);
    const suppressContextMenu = getChartMetadataRegistry().get(
      props.formData.viz_type ?? props.vizType,
    )?.suppressContextMenu;
        Severity: Minor
        Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 1 hr to fix

          Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            render() {
    const { chartAlert, chartStatus, chartId, emitCrossFilters } = this.props;

    // Skip chart rendering
    if (chartStatus === 'loading' || !!chartAlert || chartStatus === null) {
          Severity: Minor
          Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function shouldComponentUpdate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            shouldComponentUpdate(nextProps, nextState) {
    const resultsReady =
      nextProps.queriesResponse &&
      ['success', 'rendered'].indexOf(nextProps.chartStatus) > -1 &&
      !nextProps.queriesResponse?.[0]?.error;
          Severity: Minor
          Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 1 hr to fix

            Function shouldComponentUpdate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              shouldComponentUpdate(nextProps, nextState) {
    const resultsReady =
      nextProps.queriesResponse &&
      ['success', 'rendered'].indexOf(nextProps.chartStatus) > -1 &&
      !nextProps.queriesResponse?.[0]?.error;
            Severity: Minor
            Found in superset-frontend/src/components/Chart/ChartRenderer.jsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const {
      width,
      height,
      datasource,
      annotationData,
            Severity: Major
            Found in superset-frontend/src/components/Chart/ChartRenderer.jsx and 1 other location - About 1 hr to fix
            superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx on lines 187..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status