airbnb/caravel

View on GitHub
superset-frontend/src/components/Chart/chartReducer.ts

Summary

Maintainability
C
1 day
Test Coverage

Function chartReducer has 165 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function chartReducer(
  charts: Record<string, ChartState> = {},
  action: AnyChartAction,
) {
  const actionHandlers: Record<string, ChartActionHandler> = {
Severity: Major
Found in superset-frontend/src/components/Chart/chartReducer.ts - About 6 hrs to fix

    Function chartReducer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function chartReducer(
      charts: Record<string, ChartState> = {},
      action: AnyChartAction,
    ) {
      const actionHandlers: Record<string, ChartActionHandler> = {
    Severity: Minor
    Found in superset-frontend/src/components/Chart/chartReducer.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return {
          ...charts,
          [action.key]: actionHandlers[action.type](charts[action.key]),
        };
    Severity: Major
    Found in superset-frontend/src/components/Chart/chartReducer.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return charts;
      Severity: Major
      Found in superset-frontend/src/components/Chart/chartReducer.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status