Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/components/Datasource/CollectionTable.tsx

Summary

Maintainability
D
2 days
Test Coverage

File CollectionTable.tsx has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/src/components/Datasource/CollectionTable.tsx - About 6 hrs to fix

    Function renderItem has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      renderItem(record: any) {
    const { allowAddItem, allowDeletes, expandFieldset, tableColumns } =
      this.props;
    /* eslint-disable no-underscore-dangle */
    const isExpanded =
    Severity: Major
    Found in superset-frontend/src/components/Datasource/CollectionTable.tsx - About 2 hrs to fix

      CRUDCollection has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export default class CRUDCollection extends PureComponent<
  CRUDCollectionProps,
  CRUDCollectionState
> {
  constructor(props: CRUDCollectionProps) {
      Severity: Minor
      Found in superset-frontend/src/components/Datasource/CollectionTable.tsx - About 2 hrs to fix

        Function sortColumn has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          sortColumn(col: string, sort = SortOrder.Unsorted) {
    const { sortColumns } = this.props;
    // default sort logic sorting string, boolean and number
    const compareSort = (m: Sort, n: Sort) => {
      if (typeof m === 'string') {
        Severity: Minor
        Found in superset-frontend/src/components/Datasource/CollectionTable.tsx - About 1 hr to fix

          Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render() {
    return (
      <>
        <CrudButtonWrapper>
          {this.props.allowAddItem && (
          Severity: Minor
          Found in superset-frontend/src/components/Datasource/CollectionTable.tsx - About 1 hr to fix

            Function renderItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              renderItem(record: any) {
    const { allowAddItem, allowDeletes, expandFieldset, tableColumns } =
      this.props;
    /* eslint-disable no-underscore-dangle */
    const isExpanded =
            Severity: Minor
            Found in superset-frontend/src/components/Datasource/CollectionTable.tsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (this.state.sortColumn === col && this.state.sort === SortOrder.Asc) {
      return <Icons.SortAsc onClick={this.sortColumn(col, 2)} />;
    }
            Severity: Major
            Found in superset-frontend/src/components/Datasource/CollectionTable.tsx and 1 other location - About 1 hr to fix
            superset-frontend/src/components/Datasource/CollectionTable.tsx on lines 323..325

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (this.state.sortColumn === col && this.state.sort === SortOrder.Desc) {
      return <Icons.SortDesc onClick={this.sortColumn(col, 0)} />;
    }
            Severity: Major
            Found in superset-frontend/src/components/Datasource/CollectionTable.tsx and 1 other location - About 1 hr to fix
            superset-frontend/src/components/Datasource/CollectionTable.tsx on lines 320..322

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

            const StyledButtonWrapper = styled.span`
  ${({ theme }) => `
    margin-top: ${theme.gridUnit * 3}px;
    margin-left: ${theme.gridUnit * 3}px;
  `}
            Severity: Major
            Found in superset-frontend/src/components/Datasource/CollectionTable.tsx and 6 other locations - About 1 hr to fix
            superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx on lines 50..64
            superset-frontend/src/features/databases/DatabaseModal/index.tsx on lines 128..132
            superset-frontend/src/features/datasets/AddDataset/DatasetPanel/DatasetPanel.tsx on lines 88..103
            superset-frontend/src/features/datasets/AddDataset/EditDataset/index.tsx on lines 37..44
            superset-frontend/src/features/datasets/DatasetSelectLabel/index.tsx on lines 52..60
            superset-frontend/src/features/datasets/DatasetSelectLabel/index.tsx on lines 62..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 10 locations. Consider refactoring.
            Open

            const CrudButtonWrapper = styled.div`
  text-align: right;
  ${({ theme }) => `margin-bottom: ${theme.gridUnit * 2}px`}
`;
            Severity: Major
            Found in superset-frontend/src/components/Datasource/CollectionTable.tsx and 9 other locations - About 50 mins to fix
            superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx on lines 45..53
            superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/DividerConfigForm.tsx on lines 31..35
            superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx on lines 114..121
            superset-frontend/src/explore/components/DataTableControl/index.tsx on lines 152..157
            superset-frontend/src/explore/components/DataTablesPane/components/DataTableControls.tsx on lines 31..42
            superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx on lines 32..34
            superset-frontend/src/explore/components/DataTablesPane/components/useResultsPane.tsx on lines 35..37
            superset-frontend/src/features/databases/DatabaseModal/index.tsx on lines 134..138
            superset-frontend/src/features/home/ActivityTable.tsx on lines 78..83

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status