Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/components/Datasource/DatasourceModal.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function onConfirmSave has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const onConfirmSave = () => {
    // Pull out extra fields into the extra object
    const schema =
      currentDatasource.tableSelector?.schema ||
      currentDatasource.databaseSelector?.schema ||
Severity: Major
Found in superset-frontend/src/components/Datasource/DatasourceModal.tsx - About 4 hrs to fix

    File DatasourceModal.tsx has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/src/components/Datasource/DatasourceModal.tsx - About 3 hrs to fix

      Function DatasourceModal has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
  addSuccessToast,
  datasource,
  onDatasourceSave,
  onHide,
      Severity: Minor
      Found in superset-frontend/src/components/Datasource/DatasourceModal.tsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status