Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/dashboard/components/gridComponents/Header.jsx

Summary

Maintainability
C
7 hrs
Test Coverage

Function render has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { isFocused } = this.state;

    const {
      dashboardId,
Severity: Major
Found in superset-frontend/src/dashboard/components/gridComponents/Header.jsx - About 3 hrs to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      handleUpdateMeta(metaKey, nextValue) {
    const { updateComponents, component } = this.props;
    if (nextValue && component.meta[metaKey] !== nextValue) {
      updateComponents({
        [component.id]: {
    Severity: Major
    Found in superset-frontend/src/dashboard/components/gridComponents/Header.jsx and 2 other locations - About 2 hrs to fix
    superset-frontend/src/dashboard/components/gridComponents/Column.jsx on lines 145..158
    superset-frontend/src/dashboard/components/gridComponents/Row.jsx on lines 217..230

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <BackgroundStyleDropdown
                  id={`${component.id}-background`}
                  value={component.meta.background}
                  onChange={this.handleChangeBackground}
                />,
    Severity: Minor
    Found in superset-frontend/src/dashboard/components/gridComponents/Header.jsx and 1 other location - About 55 mins to fix
    superset-frontend/src/dashboard/components/gridComponents/Column.jsx on lines 216..220

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        const {
      dashboardId,
      component,
      depth,
      parentComponent,
    Severity: Minor
    Found in superset-frontend/src/dashboard/components/gridComponents/Header.jsx and 2 other locations - About 35 mins to fix
    superset-frontend/plugins/legacy-plugin-chart-paired-t-test/src/PairedTTest.jsx on lines 120..121
    superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx on lines 785..793

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status