Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/dashboard/components/gridComponents/Row.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has 159 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const {
      component: rowComponent,
      parentComponent,
      index,
Severity: Major
Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx - About 6 hrs to fix

    File Row.jsx has 363 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx - About 4 hrs to fix

      Function componentDidMount has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        componentDidMount() {
    if (
      isFeatureEnabled(FeatureFlag.DashboardVirtualization) &&
      !isCurrentUserBot()
    ) {
      Severity: Minor
      Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx - About 1 hr to fix

        Function componentDidMount has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          componentDidMount() {
    if (
      isFeatureEnabled(FeatureFlag.DashboardVirtualization) &&
      !isCurrentUserBot()
    ) {
        Severity: Minor
        Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          handleUpdateMeta(metaKey, nextValue) {
    const { updateComponents, component } = this.props;
    if (nextValue && component.meta[metaKey] !== nextValue) {
      updateComponents({
        [component.id]: {
        Severity: Major
        Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx and 2 other locations - About 2 hrs to fix
        superset-frontend/src/dashboard/components/gridComponents/Column.jsx on lines 145..158
        superset-frontend/src/dashboard/components/gridComponents/Header.jsx on lines 138..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            const {
      component: rowComponent,
      parentComponent,
      index,
      availableColumnCount,
        Severity: Major
        Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx and 2 other locations - About 2 hrs to fix
        superset-frontend/src/dashboard/components/gridComponents/Column.jsx on lines 161..176
        superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx on lines 315..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      <HoverMenu
                onHover={this.handleMenuHover}
                innerRef={dragSourceRef}
                position="left"
              >
        Severity: Major
        Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx and 1 other location - About 2 hrs to fix
        superset-frontend/src/dashboard/components/gridComponents/Column.jsx on lines 225..234

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              <Draggable
        component={rowComponent}
        parentComponent={parentComponent}
        orientation="row"
        index={index}
        Severity: Major
        Found in superset-frontend/src/dashboard/components/gridComponents/Row.jsx and 2 other locations - About 50 mins to fix
        superset-frontend/src/dashboard/components/gridComponents/Column.jsx on lines 186..313
        superset-frontend/src/dashboard/components/gridComponents/Divider.jsx on lines 87..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status