Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/dashboard/util/getRelatedCharts.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function getRelatedCharts has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

export function getRelatedCharts(
  filters: Record<
    string,
    AppliedNativeFilterType | AppliedCrossFilterType | Filter
  >,
Severity: Minor
Found in superset-frontend/src/dashboard/util/getRelatedCharts.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRelatedCharts has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getRelatedCharts(
  filters: Record<
    string,
    AppliedNativeFilterType | AppliedCrossFilterType | Filter
  >,
Severity: Minor
Found in superset-frontend/src/dashboard/util/getRelatedCharts.ts - About 1 hr to fix

    Function related has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const related = Object.entries(filters).reduce((acc, [filterKey, filter]) => {
    const isCrossFilter =
      Object.keys(slices).includes(filterKey) &&
      isAppliedCrossFilterType(filter);
    Severity: Minor
    Found in superset-frontend/src/dashboard/util/getRelatedCharts.ts - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status