Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function DndFilterSelect has 348 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const DndFilterSelect = (props: DndFilterSelectProps) => {
  const {
    datasource,
    onChange = () => {},
    name: controlName,
Severity: Major
Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 1 day to fix

    Function DndFilterSelect has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
    Open

    const DndFilterSelect = (props: DndFilterSelectProps) => {
  const {
    datasource,
    onChange = () => {},
    name: controlName,
    Severity: Minor
    Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File DndFilterSelect.tsx has 407 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with work for additional information
 * regarding copyright ownership.  The ASF licenses file
    Severity: Minor
    Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 5 hrs to fix

      Function optionsForSelect has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const optionsForSelect = (
    columns: ColumnMeta[],
    formData: QueryFormData | null | undefined,
  ) => {
    const options: OptionSortType[] = [
      Severity: Minor
      Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 1 hr to fix

        Function mapOption has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            (option: OptionValueType) => {
      // already a AdhocFilter, skip
      if (option instanceof AdhocFilter) {
        return option;
      }
        Severity: Minor
        Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 1 hr to fix

          Function adhocFilter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const adhocFilter = useMemo(() => {
    if (isSavedMetric(droppedItem)) {
      return new AdhocFilter({
        expressionType: ExpressionTypes.Sql,
        clause: Clauses.Having,
          Severity: Minor
          Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                  return null;
            Severity: Major
            Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                const extra = useMemo<{ disallow_adhoc_metrics?: boolean }>(() => {
    let extra = {};
    if (datasource?.extra) {
      try {
        extra = JSON.parse(datasource.extra);
              Severity: Major
              Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx and 1 other location - About 2 hrs to fix
              superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx on lines 110..118

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const onShiftOptions = useCallback(
    (dragIndex: number, hoverIndex: number) => {
      const newValues = [...values];
      [newValues[hoverIndex], newValues[dragIndex]] = [
        newValues[dragIndex],
              Severity: Major
              Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx and 1 other location - About 2 hrs to fix
              superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx on lines 233..243

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 76.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                      <DndAdhocFilterOption
          index={index}
          adhocFilter={adhocFilter}
          options={options}
          datasource={datasource}
              Severity: Major
              Found in superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx and 4 other locations - About 1 hr to fix
              superset-frontend/src/components/TableView/TableView.tsx on lines 211..220
              superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/ScopingModal/ScopingModal.tsx on lines 312..321
              superset-frontend/src/features/databases/DatabaseModal/index.tsx on lines 1734..1743
              superset-frontend/src/features/databases/DatabaseModal/index.tsx on lines 1936..1945

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status