Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/explore/components/controls/SelectControl.jsx

Summary

Maintainability
B
7 hrs
Test Coverage

Function render has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const {
      ariaLabel,
      autoFocus,
      clearable,
Severity: Major
Found in superset-frontend/src/explore/components/controls/SelectControl.jsx - About 4 hrs to fix

    Function render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      render() {
    const {
      ariaLabel,
      autoFocus,
      clearable,
    Severity: Minor
    Found in superset-frontend/src/explore/components/controls/SelectControl.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function innerGetOptions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const innerGetOptions = props => {
  const { choices, optionRenderer, valueKey } = props;
  let options = [];
  if (props.options) {
    options = props.options.map(o => ({
    Severity: Minor
    Found in superset-frontend/src/explore/components/controls/SelectControl.jsx - About 1 hr to fix

      Function onChange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        onChange(val) {
    // will eventually call `exploreReducer`: SET_FIELD_VALUE
    const { valueKey } = this.props;
    let onChangeVal = val;
      Severity: Minor
      Found in superset-frontend/src/explore/components/controls/SelectControl.jsx - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status