Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/explore/components/controls/TextAreaControl.jsx

Summary

Maintainability
A
2 hrs
Test Coverage

Function renderEditor has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  renderEditor(inModal = false) {
    const minLines = inModal ? 40 : this.props.minLines || 12;
    if (this.props.language) {
      const style = {
        border: `1px solid ${this.props.theme.colors.grayscale.light1}`,
Severity: Minor
Found in superset-frontend/src/explore/components/controls/TextAreaControl.jsx - About 1 hr to fix

    Function renderEditor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      renderEditor(inModal = false) {
    const minLines = inModal ? 40 : this.props.minLines || 12;
    if (this.props.language) {
      const style = {
        border: `1px solid ${this.props.theme.colors.grayscale.light1}`,
    Severity: Minor
    Found in superset-frontend/src/explore/components/controls/TextAreaControl.jsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status