Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function mergeNativeFiltersToFormData has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const mergeNativeFiltersToFormData = (
  exploreFormData: QueryFormData,
  dashboardFormData: JsonObject,
) => {
  const nativeFiltersData: JsonObject = {};
Severity: Minor
Found in superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts - About 1 hr to fix

    Function getFormDataWithDashboardContext has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const getFormDataWithDashboardContext = (
  exploreFormData: QueryFormData,
  dashboardContextFormData: JsonObject,
) => {
  const filterBoxData = mergeFilterBoxToFormData(
    Severity: Minor
    Found in superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts - About 1 hr to fix

      Function mergeFilterBoxToFormData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const mergeFilterBoxToFormData = (
  exploreFormData: QueryFormData,
  dashboardFormData: JsonObject,
) => {
  const dateColumns = {
      Severity: Minor
      Found in superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts - About 1 hr to fix

        Function removeAdhocFilterDuplicates has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const removeAdhocFilterDuplicates = (filters: AdhocFilter[]) => {
  const isDuplicate = (
    adhocFilter: AdhocFilter,
    existingFilters: AdhocFilter[],
  ) =>
        Severity: Minor
        Found in superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  (isSimpleAdhocFilter(existingFilter) &&
          isSimpleAdhocFilter(adhocFilter) &&
          existingFilter.operator === adhocFilter.operator &&
          existingFilter.subject === adhocFilter.subject &&
          ((!('comparator' in existingFilter) &&
          Severity: Minor
          Found in superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts and 1 other location - About 35 mins to fix
          superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts on lines 54..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  (isFreeFormAdhocFilter(existingFilter) &&
          isFreeFormAdhocFilter(adhocFilter) &&
          existingFilter.clause === adhocFilter.clause &&
          existingFilter.sqlExpression === adhocFilter.sqlExpression) ||
        (isSimpleAdhocFilter(existingFilter) &&
          Severity: Minor
          Found in superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts and 1 other location - About 35 mins to fix
          superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts on lines 58..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status