Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/features/home/RightMenu.test.tsx

Summary

Maintainability
B
5 hrs
Test Coverage

File RightMenu.test.tsx has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/src/features/home/RightMenu.test.tsx - About 3 hrs to fix

    Function resetUseSelectorMock has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const resetUseSelectorMock = () => {
  useSelectorMock.mockReturnValueOnce({
    createdOn: '2021-04-27T18:12:38.952304',
    email: 'admin',
    firstName: 'admin',
    Severity: Minor
    Found in superset-frontend/src/features/home/RightMenu.test.tsx - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          languages: {
      en: {
        flag: 'us',
        name: 'English',
        url: '/lang/en',
      Severity: Minor
      Found in superset-frontend/src/features/home/RightMenu.test.tsx and 2 other locations - About 40 mins to fix
      superset-frontend/src/features/home/LanguagePicker.test.tsx on lines 26..37
      superset-frontend/src/features/home/Menu.test.tsx on lines 188..199

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status