Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/pages/Chart/index.tsx

Summary

Maintainability
B
5 hrs
Test Coverage

Function ExplorePage has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function ExplorePage() {
  const [isLoaded, setIsLoaded] = useState(false);
  const isExploreInitialized = useRef(false);
  const dispatch = useDispatch();
  const location = useLocation();
Severity: Minor
Found in superset-frontend/src/pages/Chart/index.tsx - About 1 hr to fix

    Function fetchExploreData has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const fetchExploreData = async (exploreUrlParams: URLSearchParams) => {
  try {
    const rv = await makeApi<{}, ExploreResponsePayload>({
      method: 'GET',
      endpoint: 'api/v1/explore/',
    Severity: Minor
    Found in superset-frontend/src/pages/Chart/index.tsx - About 1 hr to fix

      Function getDashboardContextFormData has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const getDashboardContextFormData = () => {
  const dashboardPageId = getUrlParam(URL_PARAMS.dashboardPageId);
  const dashboardContext = getDashboardPageContext(dashboardPageId);
  if (dashboardContext) {
    const sliceId = getUrlParam(URL_PARAMS.sliceId) || 0;
      Severity: Minor
      Found in superset-frontend/src/pages/Chart/index.tsx - About 1 hr to fix

        Function fetchExploreData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        const fetchExploreData = async (exploreUrlParams: URLSearchParams) => {
  try {
    const rv = await makeApi<{}, ExploreResponsePayload>({
      method: 'GET',
      endpoint: 'api/v1/explore/',
        Severity: Minor
        Found in superset-frontend/src/pages/Chart/index.tsx - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

            const {
      labelsColor,
      labelsColorMap,
      colorScheme,
      chartConfiguration,
        Severity: Major
        Found in superset-frontend/src/pages/Chart/index.tsx and 8 other locations - About 40 mins to fix
        superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts on lines 49..58
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx on lines 45..54
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/SmoothLine/controlPanel.tsx on lines 45..54
        superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/transformProps.ts on lines 152..161
        superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts on lines 151..160
        superset-frontend/src/components/Label/index.tsx on lines 55..64
        superset-frontend/src/dashboard/containers/Dashboard.ts on lines 39..48
        superset-frontend/src/filters/components/TimeColumn/transformProps.ts on lines 24..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status