airbnb/caravel

View on GitHub
superset-frontend/src/pages/DatabaseList/index.tsx

Summary

Maintainability
F
5 days
Test Coverage

File index.tsx has 593 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Major
Found in superset-frontend/src/pages/DatabaseList/index.tsx - About 1 day to fix

    Function DatabaseList has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function DatabaseList({
      addDangerToast,
      addSuccessToast,
      user,
    }: DatabaseListProps) {
    Severity: Minor
    Found in superset-frontend/src/pages/DatabaseList/index.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      const hasFileUploadEnabled = () => {
        const payload = {
          filters: [
            { col: 'allow_file_upload', opr: 'upload_is_enabled', value: true },
          ],
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 1 other location - About 6 hrs to fix
    superset-frontend/src/features/home/RightMenu.tsx on lines 240..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 166.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                  {canExport && (
                    <Tooltip
                      id="export-action-tooltip"
                      title={t('Export')}
                      placement="bottom"
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 4 other locations - About 2 hrs to fix
    superset-frontend/src/pages/ChartList/index.tsx on lines 490..505
    superset-frontend/src/pages/DashboardList/index.tsx on lines 421..436
    superset-frontend/src/pages/DatasetList/index.tsx on lines 430..445
    superset-frontend/src/pages/DatasetList/index.tsx on lines 446..461

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          {
            Header: t('Expose in SQL Lab'),
            key: 'expose_in_sql_lab',
            id: 'expose_in_sqllab',
            input: 'select',
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 1 other location - About 2 hrs to fix
    superset-frontend/src/pages/DashboardList/index.tsx on lines 505..516

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          {
            Cell: ({
              row: {
                original: {
                  changed_by: changedBy,
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 8 other locations - About 2 hrs to fix
    superset-frontend/src/pages/AlertReportList/index.tsx on lines 319..331
    superset-frontend/src/pages/AnnotationLayerList/index.tsx on lines 156..168
    superset-frontend/src/pages/ChartList/index.tsx on lines 430..442
    superset-frontend/src/pages/DashboardList/index.tsx on lines 365..377
    superset-frontend/src/pages/DatasetList/index.tsx on lines 396..408
    superset-frontend/src/pages/RowLevelSecurityList/index.tsx on lines 148..160
    superset-frontend/src/pages/SavedQueryList/index.tsx on lines 367..379
    superset-frontend/src/pages/Tags/index.tsx on lines 177..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

    interface DatabaseListProps {
      addDangerToast: (msg: string) => void;
      addSuccessToast: (msg: string) => void;
      user: {
        userId: string | number;
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 8 other locations - About 1 hr to fix
    superset-frontend/src/pages/AnnotationLayerList/index.tsx on lines 43..51
    superset-frontend/src/pages/ChartList/index.tsx on lines 145..153
    superset-frontend/src/pages/CssTemplateList/index.tsx on lines 43..51
    superset-frontend/src/pages/DashboardList/index.tsx on lines 86..94
    superset-frontend/src/pages/DatasetList/index.tsx on lines 132..140
    superset-frontend/src/pages/RowLevelSecurityList/index.tsx on lines 44..52
    superset-frontend/src/pages/SavedQueryList/index.tsx on lines 78..86
    superset-frontend/src/pages/Tags/index.tsx on lines 48..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          {
            accessor: 'allow_file_upload',
            Header: t('File upload'),
            Cell: ({
              row: {
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 1 other location - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 401..410

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          {
            accessor: 'expose_in_sqllab',
            Header: t('Expose in SQL Lab'),
            Cell: ({
              row: {
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 1 other location - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 391..400

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          <UploadDataModal
            addDangerToast={addDangerToast}
            addSuccessToast={addSuccessToast}
            onHide={() => {
              setCsvUploadDataModalOpen(false);
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 587..596
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 597..606

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          <UploadDataModal
            addDangerToast={addDangerToast}
            addSuccessToast={addSuccessToast}
            onHide={() => {
              setExcelUploadDataModalOpen(false);
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 577..586
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 597..606

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          <UploadDataModal
            addDangerToast={addDangerToast}
            addSuccessToast={addSuccessToast}
            onHide={() => {
              setColumnarUploadDataModalOpen(false);
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 577..586
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 587..596

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            Header: (
              <Tooltip
                id="allow-dml-header-tooltip"
                title={t('Allow data manipulation language')}
                placement="top"
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 355..363
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 523..531

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            Header: (
              <Tooltip
                id="allow-run-async-header-tooltip"
                title={t('Asynchronous query execution')}
                placement="top"
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 375..383
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 523..531

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            Header: (
              <Tooltip
                id="allow-run-async-filter-header-tooltip"
                title={t('Asynchronous query execution')}
                placement="top"
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 1 hr to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 355..363
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 375..383

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {
              label: t('Upload Excel'),
              name: 'Upload Excel file',
              url: '#',
              onClick: () => {
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 50 mins to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 241..250
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 261..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {
              label: t('Upload CSV'),
              name: 'Upload CSV file',
              url: '#',
              onClick: () => {
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 50 mins to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 251..260
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 261..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {
              label: t('Upload Columnar'),
              name: 'Upload columnar file',
              url: '#',
              onClick: () => {
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 2 other locations - About 50 mins to fix
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 241..250
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 251..260

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    const IconCheck = styled(Icons.Check)`
      color: ${({ theme }) => theme.colors.grayscale.dark1};
    `;
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 10 other locations - About 45 mins to fix
    superset-frontend/src/components/IndeterminateCheckbox/index.tsx on lines 38..41
    superset-frontend/src/components/IndeterminateCheckbox/index.tsx on lines 43..46
    superset-frontend/src/components/IndeterminateCheckbox/index.tsx on lines 48..51
    superset-frontend/src/components/ListView/Filters/Search.tsx on lines 37..39
    superset-frontend/src/components/Tabs/Tabs.tsx on lines 126..128
    superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx on lines 105..107
    superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx on lines 53..55
    superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx on lines 57..62
    superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx on lines 46..48
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 86..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    const IconCancelX = styled(Icons.CancelX)`
      color: ${({ theme }) => theme.colors.grayscale.light1};
    `;
    Severity: Major
    Found in superset-frontend/src/pages/DatabaseList/index.tsx and 10 other locations - About 45 mins to fix
    superset-frontend/src/components/IndeterminateCheckbox/index.tsx on lines 38..41
    superset-frontend/src/components/IndeterminateCheckbox/index.tsx on lines 43..46
    superset-frontend/src/components/IndeterminateCheckbox/index.tsx on lines 48..51
    superset-frontend/src/components/ListView/Filters/Search.tsx on lines 37..39
    superset-frontend/src/components/Tabs/Tabs.tsx on lines 126..128
    superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx on lines 105..107
    superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx on lines 53..55
    superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitleContainer.tsx on lines 57..62
    superset-frontend/src/explore/components/controls/ColorSchemeControl/index.tsx on lines 46..48
    superset-frontend/src/pages/DatabaseList/index.tsx on lines 82..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status