Sign upLogin

airbnb/caravel

View on GitHub
Star
superset-frontend/src/pages/Tags/index.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function TagList has 324 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function TagList(props: TagListProps) {
  const { addDangerToast, addSuccessToast, user } = props;
  const { userId } = user;

  const initialFilters = useMemo(
Severity: Major
Found in superset-frontend/src/pages/Tags/index.tsx - About 1 day to fix

    File index.tsx has 363 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/src/pages/Tags/index.tsx - About 4 hrs to fix

      Function filters has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const filters: Filters = useMemo(() => {
    const filters_list = [
      {
        Header: t('Name'),
        id: 'name',
      Severity: Minor
      Found in superset-frontend/src/pages/Tags/index.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              {
        Cell: ({
          row: {
            original: { id },
          },
        Severity: Major
        Found in superset-frontend/src/pages/Tags/index.tsx and 1 other location - About 3 hrs to fix
        superset-frontend/src/pages/ChartList/index.tsx on lines 314..332

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                      {canEdit && (
                <Tooltip
                  id="edit-action-tooltip"
                  title={t('Edit')}
                  placement="bottom"
        Severity: Major
        Found in superset-frontend/src/pages/Tags/index.tsx and 3 other locations - About 2 hrs to fix
        superset-frontend/src/pages/ChartList/index.tsx on lines 506..521
        superset-frontend/src/pages/DashboardList/index.tsx on lines 437..452
        superset-frontend/src/pages/RowLevelSecurityList/index.tsx on lines 202..217

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          const sortTypes = [
    {
      desc: false,
      id: 'name',
      label: t('Alphabetical'),
        Severity: Major
        Found in superset-frontend/src/pages/Tags/index.tsx and 2 other locations - About 2 hrs to fix
        superset-frontend/src/pages/ChartList/index.tsx on lines 693..712
        superset-frontend/src/pages/DashboardList/index.tsx on lines 590..609

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

              {
        Cell: ({
          row: {
            original: {
              changed_on_delta_humanized: changedOn,
        Severity: Major
        Found in superset-frontend/src/pages/Tags/index.tsx and 8 other locations - About 2 hrs to fix
        superset-frontend/src/pages/AlertReportList/index.tsx on lines 319..331
        superset-frontend/src/pages/AnnotationLayerList/index.tsx on lines 156..168
        superset-frontend/src/pages/ChartList/index.tsx on lines 430..442
        superset-frontend/src/pages/DashboardList/index.tsx on lines 365..377
        superset-frontend/src/pages/DatabaseList/index.tsx on lines 411..423
        superset-frontend/src/pages/DatasetList/index.tsx on lines 396..408
        superset-frontend/src/pages/RowLevelSecurityList/index.tsx on lines 148..160
        superset-frontend/src/pages/SavedQueryList/index.tsx on lines 367..379

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

        interface TagListProps {
  addDangerToast: (msg: string) => void;
  addSuccessToast: (msg: string) => void;
  user: {
    userId: string | number;
        Severity: Major
        Found in superset-frontend/src/pages/Tags/index.tsx and 8 other locations - About 1 hr to fix
        superset-frontend/src/pages/AnnotationLayerList/index.tsx on lines 43..51
        superset-frontend/src/pages/ChartList/index.tsx on lines 145..153
        superset-frontend/src/pages/CssTemplateList/index.tsx on lines 43..51
        superset-frontend/src/pages/DashboardList/index.tsx on lines 86..94
        superset-frontend/src/pages/DatabaseList/index.tsx on lines 72..80
        superset-frontend/src/pages/DatasetList/index.tsx on lines 132..140
        superset-frontend/src/pages/RowLevelSecurityList/index.tsx on lines 44..52
        superset-frontend/src/pages/SavedQueryList/index.tsx on lines 78..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status