Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/async_events/async_query_manager.py

Summary

Maintainability
A
1 hr
Test Coverage

Function submit_explore_json_job has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def submit_explore_json_job(
Severity: Minor
Found in superset/async_events/async_query_manager.py - About 35 mins to fix

    Function register_request_handlers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def register_request_handlers(self, app: Flask) -> None:
        @app.after_request
        def validate_session(response: Response) -> Response:
            user_id = get_user_id()
    Severity: Minor
    Found in superset/async_events/async_query_manager.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function read_events has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def read_events(
        self, channel: str, last_id: Optional[str]
    ) -> list[Optional[dict[str, Any]]]:
        if not self._cache:
            raise CacheBackendNotInitialized("Cache backend not initialized")
    Severity: Minor
    Found in superset/async_events/async_query_manager.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status