Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/commands/dashboard/importers/v0.py

Summary

Maintainability
C
1 day
Test Coverage

Function import_dashboard has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

def import_dashboard(
    # pylint: disable=too-many-locals,too-many-statements
    dashboard_to_import: Dashboard,
    dataset_id_mapping: Optional[dict[int, int]] = None,
    import_time: Optional[int] = None,
Severity: Minor
Found in superset/commands/dashboard/importers/v0.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File v0.py has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Minor
Found in superset/commands/dashboard/importers/v0.py - About 2 hrs to fix

    Function import_dashboard has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def import_dashboard(
    # pylint: disable=too-many-locals,too-many-statements
    dashboard_to_import: Dashboard,
    dataset_id_mapping: Optional[dict[int, int]] = None,
    import_time: Optional[int] = None,
    Severity: Minor
    Found in superset/commands/dashboard/importers/v0.py - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return datetime.strptime(o["__datetime__"], "%Y-%m-%dT%H:%M:%S")
      Severity: Major
      Found in superset/commands/dashboard/importers/v0.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return o
        Severity: Major
        Found in superset/commands/dashboard/importers/v0.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return SqlMetric(**o["__SqlMetric__"])
          Severity: Major
          Found in superset/commands/dashboard/importers/v0.py - About 30 mins to fix

            Function decode_dashboards has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def decode_dashboards(o: dict[str, Any]) -> Any:
    """
    Function to be passed into json.loads obj_hook parameter
    Recreates the dashboard object from a json representation.
    """
            Severity: Minor
            Found in superset/commands/dashboard/importers/v0.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status