Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/common/query_context_factory.py

Summary

Maintainability
C
1 day
Test Coverage

Function _apply_granularity has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    def _apply_granularity(
        self,
        query_object: QueryObject,
        form_data: dict[str, Any] | None,
        datasource: BaseDatasource,
Severity: Minor
Found in superset/common/query_context_factory.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create(  # pylint: disable=too-many-arguments
Severity: Major
Found in superset/common/query_context_factory.py - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if post_processing.get("operation") == "pivot":
                            post_processing["options"]["index"] = [granularity]

            # If no temporal x-axis, then get the default temporal filter
            if not filter_to_remove:
    Severity: Major
    Found in superset/common/query_context_factory.py - About 45 mins to fix

      Function _apply_filters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _apply_filters(self, query_object: QueryObject) -> None:
        if query_object.time_range:
            for filter_object in query_object.filter:
                if filter_object["op"] == "TEMPORAL_RANGE":
                    filter_object["val"] = query_object.time_range
      Severity: Minor
      Found in superset/common/query_context_factory.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status