Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/databases/api.py

Summary

Maintainability
F
6 days
Test Coverage

File api.py has 2138 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/databases/api.py - About 5 days to fix

    Function post has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def post(self) -> FlaskResponse:
        """Create a new database.
        ---
        post:
          summary: Create a new database
    Severity: Minor
    Found in superset/databases/api.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function put has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def put(self, pk: int) -> Response:
        """Update a database.
        ---
        put:
          summary: Change a database
    Severity: Minor
    Found in superset/databases/api.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return self.response(ex.status, message=ex.message)
    Severity: Major
    Found in superset/databases/api.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return json_errors_response(errors=ex.errors, status=ex.status)
      Severity: Major
      Found in superset/databases/api.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return self.response_400(message=str(ex))
        Severity: Major
        Found in superset/databases/api.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return self.response_422(message=str(ex))
          Severity: Major
          Found in superset/databases/api.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return self.response_422(message=str(ex))
            Severity: Major
            Found in superset/databases/api.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return self.response_400(message=str(ex))
              Severity: Major
              Found in superset/databases/api.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return self.response_422(message=str(ex))
                Severity: Major
                Found in superset/databases/api.py - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status