Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/db_engine_specs/bigquery.py

Summary

Maintainability
D
2 days
Test Coverage

File bigquery.py has 588 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/db_engine_specs/bigquery.py - About 1 day to fix

    BigQueryEngineSpec has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class BigQueryEngineSpec(BaseEngineSpec):  # pylint: disable=too-many-public-methods
    """Engine spec for Google's BigQuery

    As contributed by @mxmzdlv on issue #945"""
    Severity: Minor
    Found in superset/db_engine_specs/bigquery.py - About 3 hrs to fix

      Function select_star has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def select_star(  # pylint: disable=too-many-arguments
      Severity: Major
      Found in superset/db_engine_specs/bigquery.py - About 1 hr to fix

        Function estimate_query_cost has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def estimate_query_cost(  # pylint: disable=too-many-arguments
        Severity: Minor
        Found in superset/db_engine_specs/bigquery.py - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                  return None
          Severity: Major
          Found in superset/db_engine_specs/bigquery.py - About 30 mins to fix

            Function custom_estimate_statement_cost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def custom_estimate_statement_cost(
        cls,
        statement: str,
        client: bigquery.Client,
    ) -> dict[str, Any]:
            Severity: Minor
            Found in superset/db_engine_specs/bigquery.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function df_to_sql has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def df_to_sql(
        cls,
        database: Database,
        table: Table,
        df: pd.DataFrame,
            Severity: Minor
            Found in superset/db_engine_specs/bigquery.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status