Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/db_engine_specs/hive.py

Summary

Maintainability
D
2 days
Test Coverage

File hive.py has 533 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/db_engine_specs/hive.py - About 1 day to fix

    Function handle_cursor has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        def handle_cursor(  # pylint: disable=too-many-locals
        cls, cursor: Any, query: Query
    ) -> None:
        """Updates progress information"""
        # pylint: disable=import-outside-toplevel
    Severity: Minor
    Found in superset/db_engine_specs/hive.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    HiveEngineSpec has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class HiveEngineSpec(PrestoEngineSpec):
    """Reuses PrestoEngineSpec functionality."""

    engine = "hive"
    engine_name = "Apache Hive"
    Severity: Minor
    Found in superset/db_engine_specs/hive.py - About 2 hrs to fix

      Function where_latest_partition has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def where_latest_partition(
        cls,
        database: Database,
        table: Table,
        query: Select,
      Severity: Minor
      Found in superset/db_engine_specs/hive.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function select_star has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def select_star(  # pylint: disable=too-many-arguments
      Severity: Major
      Found in superset/db_engine_specs/hive.py - About 1 hr to fix

        Function progress has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def progress(cls, log_lines: list[str]) -> int:
        total_jobs = 1  # assuming there's at least 1 job
        current_job = 1
        stages: dict[int, float] = {}
        for line in log_lines:
        Severity: Minor
        Found in superset/db_engine_specs/hive.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _partition_query has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _partition_query(  # pylint: disable=too-many-arguments
        Severity: Major
        Found in superset/db_engine_specs/hive.py - About 50 mins to fix

          Function df_to_sql has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def df_to_sql(
        cls,
        database: Database,
        table: Table,
        df: pd.DataFrame,
          Severity: Minor
          Found in superset/db_engine_specs/hive.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status