Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/db_engine_specs/trino.py

Summary

Maintainability
C
1 day
Test Coverage

File trino.py has 443 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Minor
Found in superset/db_engine_specs/trino.py - About 6 hrs to fix

    Function update_params_from_encrypted_extra has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_params_from_encrypted_extra(
        database: Database,
        params: dict[str, Any],
    ) -> None:
        if not database.encrypted_extra:
    Severity: Minor
    Found in superset/db_engine_specs/trino.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_dbapi_exception_mapping has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_dbapi_exception_mapping(cls) -> dict[type[Exception], type[Exception]]:
        # pylint: disable=import-outside-toplevel
        from requests import exceptions as requests_exceptions
        from trino import exceptions as trino_exceptions
    Severity: Minor
    Found in superset/db_engine_specs/trino.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function df_to_sql has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def df_to_sql(
    Severity: Minor
    Found in superset/db_engine_specs/trino.py - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

                      return default
      Severity: Major
      Found in superset/db_engine_specs/trino.py - About 30 mins to fix

        Function execute_with_cursor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def execute_with_cursor(
        cls,
        cursor: Cursor,
        sql: str,
        query: Query,
        Severity: Minor
        Found in superset/db_engine_specs/trino.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status