Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/models/core.py

Summary

Maintainability
F
4 days
Test Coverage

File core.py has 935 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/models/core.py - About 2 days to fix

    Database has 77 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Database(Model, AuditMixinNullable, ImportExportMixin):  # pylint: disable=too-many-public-methods
    """An ORM object that stores Database related information"""

    __tablename__ = "dbs"
    type = "table"
    Severity: Major
    Found in superset/models/core.py - About 1 day to fix

      Function _get_sqla_engine has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def _get_sqla_engine(
        self,
        catalog: str | None = None,
        schema: str | None = None,
        nullpool: bool = True,
      Severity: Minor
      Found in superset/models/core.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function select_star has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def select_star(  # pylint: disable=too-many-arguments
      Severity: Major
      Found in superset/models/core.py - About 50 mins to fix

        Function get_sqla_engine has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def get_sqla_engine(  # pylint: disable=too-many-arguments
        Severity: Minor
        Found in superset/models/core.py - About 45 mins to fix

          Function get_df has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def get_df(  # pylint: disable=too-many-locals
          Severity: Minor
          Found in superset/models/core.py - About 35 mins to fix

            Function _get_sqla_engine has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _get_sqla_engine(
            Severity: Minor
            Found in superset/models/core.py - About 35 mins to fix

              Function get_df has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_df(  # pylint: disable=too-many-locals
        self,
        sql: str,
        catalog: str | None = None,
        schema: str | None = None,
              Severity: Minor
              Found in superset/models/core.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status