Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/sql_lab.py

Summary

Maintainability
D
2 days
Test Coverage

File sql_lab.py has 544 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/sql_lab.py - About 1 day to fix

    Function execute_sql_statements has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    def execute_sql_statements(
    # pylint: disable=too-many-arguments, too-many-locals, too-many-statements, too-many-branches
    query_id: int,
    rendered_query: str,
    return_results: bool,
    Severity: Minor
    Found in superset/sql_lab.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute_sql_statement has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    def execute_sql_statement(  # pylint: disable=too-many-statements, too-many-locals
    sql_statement: str,
    query: Query,
    cursor: Any,
    log_params: Optional[dict[str, Any]],
    Severity: Minor
    Found in superset/sql_lab.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute_sql_statements has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def execute_sql_statements(
    # pylint: disable=too-many-arguments, too-many-locals, too-many-statements, too-many-branches
    query_id: int,
    rendered_query: str,
    return_results: bool,
    Severity: Minor
    Found in superset/sql_lab.py - About 1 hr to fix

      Function get_sql_results has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def get_sql_results(  # pylint: disable=too-many-arguments
      Severity: Major
      Found in superset/sql_lab.py - About 1 hr to fix

        Function execute_sql_statements has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def execute_sql_statements(
        Severity: Major
        Found in superset/sql_lab.py - About 1 hr to fix

          Function execute_sql_statement has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def execute_sql_statement(  # pylint: disable=too-many-statements, too-many-locals
          Severity: Minor
          Found in superset/sql_lab.py - About 45 mins to fix

            Function handle_query_error has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def handle_query_error(
    ex: Exception,
    query: Query,
    payload: Optional[dict[str, Any]] = None,
    prefix_message: str = "",
            Severity: Minor
            Found in superset/sql_lab.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                return None
            Severity: Major
            Found in superset/sql_lab.py - About 30 mins to fix

              Function _serialize_and_expand_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def _serialize_and_expand_data(
    result_set: SupersetResultSet,
    db_engine_spec: BaseEngineSpec,
    use_msgpack: Optional[bool] = False,
    expand_data: bool = False,
              Severity: Minor
              Found in superset/sql_lab.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status