Sign upLogin

airbnb/caravel

View on GitHub
Star
superset/views/base.py

Summary

Maintainability
D
1 day
Test Coverage

File base.py has 575 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
Severity: Major
Found in superset/views/base.py - About 1 day to fix

    Function handle_api_exception has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    def handle_api_exception(
    f: Callable[..., FlaskResponse],
) -> Callable[..., FlaskResponse]:
    """
    A decorator to catch superset exceptions. Use it after the @api decorator above
    Severity: Minor
    Found in superset/views/base.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def _delete(self: BaseView, primary_key: int) -> None:
        """
        Delete function logic, override to implement different logic
        deletes the record with primary_key = primary_key
    Severity: Minor
    Found in superset/views/base.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return json_error_response(
    Severity: Major
    Found in superset/views/base.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return json_error_response(
      Severity: Major
      Found in superset/views/base.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return json_error_response(utils.error_msg_from_exception(ex), status=422)
        Severity: Major
        Found in superset/views/base.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return json_error_response(utils.error_msg_from_exception(ex))
          Severity: Major
          Found in superset/views/base.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status