airbnb/caravel

View on GitHub
superset/views/error_handling.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function handle_api_exception has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def handle_api_exception(
    f: Callable[..., FlaskResponse],
) -> Callable[..., FlaskResponse]:
    """
    A decorator to catch superset exceptions. Use it after the @api decorator above
Severity: Minor
Found in superset/views/error_handling.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function set_app_error_handlers has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def set_app_error_handlers(app: Flask) -> None:
    """
    Set up error handlers for the Flask app
    Refer to SIP-40 and SIP-41 for more details on the error handling strategy
    """
Severity: Minor
Found in superset/views/error_handling.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return json_error_response(utils.error_msg_from_exception(ex))
Severity: Major
Found in superset/views/error_handling.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return json_error_response(
    Severity: Major
    Found in superset/views/error_handling.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return json_error_response(utils.error_msg_from_exception(ex), status=422)
      Severity: Major
      Found in superset/views/error_handling.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return json_error_response(
        Severity: Major
        Found in superset/views/error_handling.py - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status