Sign upLogin

airbnb/javascript

View on GitHub
Star

Showing 6 of 6 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if (CLIEngine) {
  /* eslint no-inner-declarations: 0 */
  const whitespaceRules = require('./whitespaceRules');

  const baseConfig = require('.');
Severity: Major
Found in packages/eslint-config-airbnb/whitespace.js and 1 other location - About 2 days to fix
packages/eslint-config-airbnb-base/whitespace.js on lines 7..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 410.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if (CLIEngine) {
  /* eslint no-inner-declarations: 0 */
  const whitespaceRules = require('./whitespaceRules');

  const baseConfig = require('.');
Severity: Major
Found in packages/eslint-config-airbnb-base/whitespace.js and 1 other location - About 2 days to fix
packages/eslint-config-airbnb/whitespace.js on lines 7..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 410.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

async function onlyErrorOnRules(rulesToError, config) {
  const errorsOnly = { ...config };
  const cli = new ESLint({
    useEslintrc: false,
    baseConfig: config
Severity: Major
Found in packages/eslint-config-airbnb/whitespace-async.js and 1 other location - About 1 day to fix
packages/eslint-config-airbnb-base/whitespace-async.js on lines 22..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 250.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

async function onlyErrorOnRules(rulesToError, config) {
  const errorsOnly = { ...config };
  const cli = new ESLint({
    useEslintrc: false,
    baseConfig: config
Severity: Major
Found in packages/eslint-config-airbnb-base/whitespace-async.js and 1 other location - About 1 day to fix
packages/eslint-config-airbnb/whitespace-async.js on lines 22..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 250.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File react.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const baseStyleRules = require('eslint-config-airbnb-base/rules/style').rules;

const dangleRules = baseStyleRules['no-underscore-dangle'];

module.exports = {
Severity: Minor
Found in packages/eslint-config-airbnb/rules/react.js - About 2 hrs to fix

    File style.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module.exports = {
  rules: {
    // enforce line breaks after opening and before closing array brackets
    // https://eslint.org/docs/rules/array-bracket-newline
    // TODO: enable? semver-major
    Severity: Minor
    Found in packages/eslint-config-airbnb-base/rules/style.js - About 2 hrs to fix
      Severity
      Category
      Status
      Source
      Language