Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts

Summary

Maintainability
F
4 days
Test Coverage

Function getTimeOffset has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

export const getTimeOffset = ({
  timeRangeFilter,
  shifts,
  startDate,
  includeFutureOffsets = true,
Severity: Minor
Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseDttmToDate has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const parseDttmToDate = (
  dttm: string,
  isEndDate = false,
  computingShifts = false,
) => {
Severity: Major
Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 4 hrs to fix

    Function parseDttmToDate has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    export const parseDttmToDate = (
  dttm: string,
  isEndDate = false,
  computingShifts = false,
) => {
    Severity: Minor
    Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File getTimeOffset.ts has 285 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 2 hrs to fix

      Function computeCustomDateTime has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const computeCustomDateTime = (
  dttm: string,
  grain: string,
  grainValue: number,
) => {
      Severity: Minor
      Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

              return now;
        Severity: Major
        Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return now;
          Severity: Major
          Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return now;
            Severity: Major
            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return now;
              Severity: Major
              Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return parsed;
                Severity: Major
                Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return null;
                  Severity: Major
                  Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return now;
                    Severity: Major
                    Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return now;
                      Severity: Major
                      Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return now;
                        Severity: Major
                        Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return shift;
                          Severity: Major
                          Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 30 mins to fix

                            Function computeCustomDateTime has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                            export const computeCustomDateTime = (
  dttm: string,
  grain: string,
  grainValue: number,
) => {
                            Severity: Minor
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                if (untilMode !== 'relative') {
      if (untilMode === 'specific') {
        customEndDate = new Date(untilDatetime);
      } else {
        customEndDate = parseDttmToDate(untilDatetime, false, true);
                            Severity: Major
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts and 2 other locations - About 1 hr to fix
                            superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 224..236
                            superset-frontend/src/explore/components/controls/TimeOffsetControl.tsx on lines 109..121

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                if (sinceMode !== 'relative') {
      if (sinceMode === 'specific') {
        customStartDate = new Date(sinceDatetime);
      } else {
        customStartDate = parseDttmToDate(sinceDatetime, false, true);
                            Severity: Major
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts and 2 other locations - About 1 hr to fix
                            superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 238..250
                            superset-frontend/src/explore/components/controls/TimeOffsetControl.tsx on lines 109..121

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    if (inInheritShift && !Number.isNaN(inInheritShift)) {
          if (includeFutureOffsets && inInheritShift < 0) {
            return `${inInheritShift * -1} days after`;
          }
          if (inInheritShift > 0) {
                            Severity: Major
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts and 1 other location - About 1 hr to fix
                            superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 291..298

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 60.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    if (customShift !== undefined && !Number.isNaN(customShift)) {
          if (includeFutureOffsets && customShift < 0) {
            return `${customShift * -1} days after`;
          }
          if (customShift >= 0) {
                            Severity: Major
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts and 1 other location - About 1 hr to fix
                            superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 301..308

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 60.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                              if (computingShifts) {
    now.setHours(-now.getTimezoneOffset() / 60, 0, 0, 0);
  } else {
    now.setHours(0, 0, 0, 0);
  }
                            Severity: Minor
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts and 1 other location - About 50 mins to fix
                            superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 138..142

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 52.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                if (computingShifts) {
      parsed.setHours(-parsed.getTimezoneOffset() / 60, 0, 0, 0);
    } else {
      parsed.setHours(0, 0, 0, 0);
    }
                            Severity: Minor
                            Found in superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts and 1 other location - About 50 mins to fix
                            superset-frontend/packages/superset-ui-core/src/time-comparison/getTimeOffset.ts on lines 39..43

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 52.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status