Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts

Summary

Maintainability
F
3 days
Test Coverage

Function transformProps has 245 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function transformProps(
  chartProps: EchartsBoxPlotChartProps,
): BoxPlotChartTransformedProps {
  const {
    width,
Severity: Major
Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts - About 1 day to fix

    Function transformProps has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function transformProps(
  chartProps: EchartsBoxPlotChartProps,
): BoxPlotChartTransformedProps {
  const {
    width,
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File transformProps.ts has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts - About 2 hrs to fix

      Function outlierData has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            metricLabels.map(metric => {
        const groupbyLabel = extractGroupbyLabel({
          datum,
          groupby: groupbyLabels,
          coltypeMapping,
      Severity: Minor
      Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts - About 1 hr to fix

        Function transformedData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            .map((datum: any) => {
      const groupbyLabel = extractGroupbyLabel({
        datum,
        groupby: groupbyLabels,
        coltypeMapping,
        Severity: Minor
        Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts - About 1 hr to fix

          Function formatter has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  formatter: (param: CallbackDataParams) => {
          // @ts-ignore
          const {
            value,
            name,
          Severity: Minor
          Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              const labelMap = data.reduce((acc: Record<string, string[]>, datum) => {
    const label = extractGroupbyLabel({
      datum,
      groupby: groupbyLabels,
      coltypeMapping,
            Severity: Major
            Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts and 1 other location - About 3 hrs to fix
            superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 178..189

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              const selectedValues = (filterState.selectedValues || []).reduce(
    (acc: Record<string, number>, selectedValue: string) => {
      const index = transformedData.findIndex(
        ({ name }) => name === selectedValue,
      );
            Severity: Major
            Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts and 4 other locations - About 2 hrs to fix
            superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts on lines 187..198
            superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 232..243
            superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts on lines 186..197
            superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts on lines 355..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              return {
    formData,
    width,
    height,
    echartOptions,
            Severity: Major
            Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts and 2 other locations - About 1 hr to fix
            superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts on lines 296..309
            superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 354..367

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 9 locations. Consider refactoring.
            Open

              const {
    width,
    height,
    formData,
    hooks,
            Severity: Major
            Found in superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts and 8 other locations - About 40 mins to fix
            superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx on lines 46..55
            superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/SmoothLine/controlPanel.tsx on lines 46..55
            superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/transformProps.ts on lines 149..158
            superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts on lines 149..158
            superset-frontend/src/components/Label/index.tsx on lines 49..58
            superset-frontend/src/dashboard/containers/Dashboard.ts on lines 39..48
            superset-frontend/src/filters/components/TimeColumn/transformProps.ts on lines 24..33
            superset-frontend/src/pages/Chart/index.tsx on lines 86..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status