Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts

Summary

Maintainability
F
3 days
Test Coverage

Function transformProps has 268 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function transformProps(
  chartProps: EchartsPieChartProps,
): PieChartTransformedProps {
  const {
    formData,
Severity: Major
Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts - About 1 day to fix

    File transformProps.ts has 369 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts - About 4 hrs to fix

      Function transformProps has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function transformProps(
  chartProps: EchartsPieChartProps,
): PieChartTransformedProps {
  const {
    formData,
      Severity: Minor
      Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function formatter has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const formatter = (params: CallbackDataParams) => {
    const [name, formattedValue, formattedPercent] = parseParams({
      params,
      numberFormatter,
    });
      Severity: Minor
      Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts - About 1 hr to fix

        Function getTotalValuePadding has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function getTotalValuePadding({
  chartPadding,
  donut,
  width,
  height,
        Severity: Minor
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const labelMap = data.reduce((acc: Record<string, string[]>, datum) => {
    const label = extractGroupbyLabel({
      datum,
      groupby: groupbyLabels,
      coltypeMapping,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts and 1 other location - About 3 hrs to fix
        superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts on lines 163..174

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

          const selectedValues = (filterState.selectedValues || []).reduce(
    (acc: Record<string, number>, selectedValue: string) => {
      const index = transformedData.findIndex(
        ({ name }) => name === selectedValue,
      );
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts and 4 other locations - About 2 hrs to fix
        superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts on lines 176..187
        superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts on lines 188..199
        superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts on lines 187..198
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts on lines 356..365

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          return {
    formData,
    width,
    height,
    echartOptions,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts and 2 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/transformProps.ts on lines 289..302
        superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts on lines 297..310

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

          const {
    formData,
    height,
    hooks,
    filterState,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts and 6 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts on lines 78..89
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts on lines 118..129
        superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts on lines 161..172
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx on lines 46..57
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx on lines 43..54
        superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts on lines 111..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (chartPadding.right) {
    padding.left = `${
      50 - ((chartPadding.right + LEGEND_WIDTH) / width / 2) * 100
    }%`;
  }
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts and 1 other location - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 107..111

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (chartPadding.left) {
    padding.left = `${
      50 + ((chartPadding.left - LEGEND_WIDTH) / width / 2) * 100
    }%`;
  }
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts and 1 other location - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 112..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status