Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts

Summary

Maintainability
F
3 days
Test Coverage

Function transformProps has 225 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function transformProps(
  chartProps: EchartsSunburstChartProps,
): SunburstTransformedProps {
  const {
    formData,
Severity: Major
Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts - About 1 day to fix

    File transformProps.ts has 361 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Minor
    Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts - About 4 hrs to fix

      Function transformProps has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function transformProps(
  chartProps: EchartsSunburstChartProps,
): SunburstTransformedProps {
  const {
    formData,
      Severity: Minor
      Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function traverse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          treeNodes.map(treeNode => {
      const { name: nodeName, value, secondaryValue, groupBy } = treeNode;
      const records = [...(pathRecords || []), nodeName];
      let name = formatSeriesName(nodeName, {
        numberFormatter,
      Severity: Minor
      Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export function formatLabel({
  params,
  labelType,
  numberFormatter,
}: {
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts and 1 other location - About 6 hrs to fix
        superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts on lines 54..76

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          return {
    formData,
    width,
    height,
    echartOptions,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts and 2 other locations - About 2 hrs to fix
        superset-frontend/plugins/plugin-chart-echarts/src/Gauge/transformProps.ts on lines 348..361
        superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts on lines 293..306

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

          const {
    formData,
    height,
    hooks,
    filterState,
        Severity: Major
        Found in superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts and 6 other locations - About 1 hr to fix
        superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts on lines 79..90
        superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts on lines 119..130
        superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts on lines 122..133
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx on lines 47..58
        superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx on lines 44..55
        superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts on lines 110..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status