Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/src/SqlLab/components/ResultSet/index.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function ResultSet has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

const ResultSet = ({
  cache = false,
  csv = true,
  database = {},
  displayLimit,
Severity: Minor
Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File index.tsx has 624 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Major
Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 1 day to fix

    Function renderRowsReturned has 110 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const renderRowsReturned = (alertMessage: boolean) => {
    const { results, rows, queryLimit, limitingFactor } = query;
    let limitMessage = '';
    const limitReached = results?.displayLimitReached;
    const limit = queryLimit || results.query.limit;
    Severity: Major
    Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 4 hrs to fix

      Function renderControls has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const renderControls = () => {
    if (search || visualize || csv) {
      let { data } = query.results;
      if (cache && query.cached) {
        data = cachedData;
      Severity: Major
      Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

            if (search || visualize || csv) {
      let { data } = query.results;
      if (cache && query.cached) {
        data = cachedData;
      }
        Severity: Critical
        Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return <Alert type="warning" message={t('The query returned no data')} />;
          Severity: Major
          Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return (
        <Button
          buttonSize="small"
          buttonStyle="primary"
          onClick={() => fetchResults(query)}
            Severity: Major
            Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return (
        <Button
          buttonSize="small"
          buttonStyle="primary"
          onClick={() =>
              Severity: Major
              Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return (
    <ResultlessStyles>
      <div>{!progressBar && <Loading position="normal" />}</div>
      {/* show loading bar whenever progress bar is completed but needs time to render */}
      <div>{query.progress === 100 && <Loading position="normal" />}</div>
                Severity: Major
                Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  const ResultlessStyles = styled.div`
  position: relative;
  min-height: ${({ theme }) => theme.gridUnit * 25}px;
  [role='alert'] {
    margin-top: ${({ theme }) => theme.gridUnit * 2}px;
                  Severity: Major
                  Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx and 1 other location - About 2 hrs to fix
                  superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx on lines 287..292

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 85.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            <SaveDatasetModal
            visible={showSaveDatasetModal}
            onHide={() => setShowSaveDatasetModal(false)}
            buttonTextOnSave={t('Save & Explore')}
            buttonTextOnOverwrite={t('Overwrite & Explore')}
                  Severity: Major
                  Found in superset-frontend/src/SqlLab/components/ResultSet/index.tsx and 1 other location - About 1 hr to fix
                  superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx on lines 149..158

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 68.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status