airbnb/superset

View on GitHub
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx

Summary

Maintainability
F
6 days
Test Coverage

Function SliceHeaderControls has 379 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const SliceHeaderControls = (props: SliceHeaderControlsPropsWithRouter) => {
  const [dropdownIsOpen, setDropdownIsOpen] = useState(false);
  const [tableModalIsOpen, setTableModalIsOpen] = useState(false);
  const [drillModalIsOpen, setDrillModalIsOpen] = useState(false);
  const [selectedKeys, setSelectedKeys] = useState<string[]>([]);

    File index.tsx has 792 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * Licensed to the Apache Software Foundation (ASF) under one
     * or more contributor license agreements.  See the NOTICE file
     * distributed with this work for additional information
     * regarding copyright ownership.  The ASF licenses this file

      Function SliceHeaderControls has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
      Open

      const SliceHeaderControls = (props: SliceHeaderControlsPropsWithRouter) => {
        const [dropdownIsOpen, setDropdownIsOpen] = useState(false);
        const [tableModalIsOpen, setTableModalIsOpen] = useState(false);
        const [drillModalIsOpen, setDrillModalIsOpen] = useState(false);
        const [selectedKeys, setSelectedKeys] = useState<string[]>([]);

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleDropdownNavigation has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const handleDropdownNavigation = (
        e: React.KeyboardEvent<HTMLElement>,
        dropdownIsOpen: boolean,
        menu: React.ReactElement,
        toggleDropdown: () => void,

        Function handleDropdownNavigation has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        export const handleDropdownNavigation = (
          e: React.KeyboardEvent<HTMLElement>,
          dropdownIsOpen: boolean,
          menu: React.ReactElement,
          toggleDropdown: () => void,

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function extractMenuItemsKeyMap has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const extractMenuItemsKeyMap = (
          children: MenuItemChildType,
        ): Record<string, any> => {
          const keysMap: Record<string, any> = {};
          const childrenArray = ensureIsArray(children);

          Function getNavigationKeys has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          const getNavigationKeys = (
            keys: string[],
            keysMap: Record<string, any>,
            currentKeyIndex: number,
            direction = 'up',

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                        <Button
                          buttonStyle="secondary"
                          buttonSize="small"
                          onClick={exploreChart}
                          disabled={!canExplore}
          superset-frontend/src/components/Chart/DrillDetail/DrillDetailModal.tsx on lines 53..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                    <Menu.Item
                      key={MenuKeys.ExportXlsx}
                      icon={<Icons.FileOutlined css={dropdownIconsStyles} />}
                    >
                      {t('Export to Excel')}
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 856..861
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 873..878
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 879..884
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 888..893

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          <Menu.Item
                            key={MenuKeys.ExportFullXlsx}
                            icon={<Icons.FileOutlined css={dropdownIconsStyles} />}
                          >
                            {t('Export to full Excel')}
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 856..861
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 862..867
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 873..878
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 888..893

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                    <Menu.Item
                      key={MenuKeys.DownloadAsImage}
                      icon={<Icons.FileImageOutlined css={dropdownIconsStyles} />}
                    >
                      {t('Download as image')}
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 856..861
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 862..867
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 873..878
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 879..884

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          <Menu.Item
                            key={MenuKeys.ExportFullCsv}
                            icon={<Icons.FileOutlined css={dropdownIconsStyles} />}
                          >
                            {t('Export to full .CSV')}
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 856..861
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 862..867
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 879..884
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 888..893

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                    <Menu.Item
                      key={MenuKeys.ExportCsv}
                      icon={<Icons.FileOutlined css={dropdownIconsStyles} />}
                    >
                      {t('Export to .CSV')}
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 862..867
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 873..878
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 879..884
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 888..893

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case NAV_KEYS.tab && e.shiftKey: {
                const { selectedKey, openKey } = getNavigationKeys(
                  keys,
                  keysMap,
                  currentKeyIndex,
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 395..405

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case NAV_KEYS.tab && !e.shiftKey: {
                const { selectedKey, openKey } = getNavigationKeys(
                  keys,
                  keysMap,
                  currentKeyIndex,
          superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx on lines 408..418

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    resizableConfig={{
                      minHeight: theme.gridUnit * 128,
                      minWidth: theme.gridUnit * 128,
                      defaultSize: {
                        width: 'auto',
          superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx on lines 444..451
          superset-frontend/src/components/Chart/DrillDetail/DrillDetailModal.tsx on lines 132..139

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status