Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/src/explore/components/ControlPanelsContainer.tsx

Summary

Maintainability
F
6 days
Test Coverage

Function ControlPanelsContainer has 503 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
  const { colors } = useTheme();
  const pluginContext = useContext(PluginContext);

  const prevState = usePrevious(props.exploreState);
Severity: Major
Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 2 days to fix

    File ControlPanelsContainer.tsx has 729 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
    Severity: Major
    Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 1 day to fix

      Function ControlPanelsContainer has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
      Open

      export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
  const { colors } = useTheme();
  const pluginContext = useContext(PluginContext);

  const prevState = usePrevious(props.exploreState);
      Severity: Minor
      Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function renderControlPanelSection has 131 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const renderControlPanelSection = (
    section: ExpandedControlPanelSectionConfig,
  ) => {
    const { controls } = props;
    const { label, description, visibility } = section;
      Severity: Major
      Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 5 hrs to fix

        Function getState has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getState(
  vizType: string,
  datasource: Dataset,
  datasourceType: DatasourceType,
) {
        Severity: Minor
        Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 1 hr to fix

          Function dataTabTitle has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const dataTabTitle = useMemo(() => {
    if (!props.errorMessage) {
      dataTabHasHadNoErrors.current = true;
    }
          Severity: Minor
          Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 1 hr to fix

            Function canDelete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  restProps.canDelete = (
        valueToBeDeleted: Record<string, any>,
        values: Record<string, any>[],
      ) => {
        const isTemporalRange = (filter: Record<string, any>) =>
            Severity: Minor
            Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                  if (
      section.tabOverride === 'data' ||
      section.controlSetRows.some(rows =>
        rows.some(
          control =>
              Severity: Major
              Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const Styles = styled.div`
  position: relative;
  height: 100%;
  width: 100%;
                Severity: Major
                Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx and 1 other location - About 2 hrs to fix
                superset-frontend/src/pages/AlertReportList/index.tsx on lines 87..92

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        <span
          css={(theme: SupersetTheme) => css`
            font-size: ${theme.typography.sizes.m}px;
            line-height: 1.3;
          `}
                Severity: Major
                Found in superset-frontend/src/explore/components/ControlPanelsContainer.tsx and 1 other location - About 1 hr to fix
                superset-frontend/src/components/Table/cell-renderers/NullCell/index.tsx on lines 25..31

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status