airbnb/superset

View on GitHub
superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx

Summary

Maintainability
F
6 days
Test Coverage

File PropertiesModal.test.tsx has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    test('"Name" should not be empty when saved', async () => {
      const props = createProps();
      renderModal(props);
    
      const name = screen.getByRole('textbox', { name: 'Name' });
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 318..337
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 339..358
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 360..379
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 381..404

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 182.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    test('"Certified by" should not be empty when saved', async () => {
      const props = createProps();
      renderModal(props);
    
      const certifiedBy = screen.getByRole('textbox', { name: 'Certified by' });
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 297..316
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 318..337
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 339..358
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 381..404

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 182.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    test('"Certification details" should not be empty when saved', async () => {
      const props = createProps();
      renderModal(props);
    
      const certificationDetails = screen.getByRole('textbox', {
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 297..316
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 318..337
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 339..358
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 360..379

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 182.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    test('"Cache timeout" should not be empty when saved', async () => {
      const props = createProps();
      renderModal(props);
    
      const cacheTimeout = screen.getByRole('textbox', { name: 'Cache timeout' });
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 297..316
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 339..358
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 360..379
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 381..404

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 182.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    test('"Description" should not be empty when saved', async () => {
      const props = createProps();
      renderModal(props);
    
      const description = screen.getByRole('textbox', { name: 'Description' });
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 297..316
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 318..337
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 360..379
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 381..404

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 182.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('"Cancel" button should call "onHide"', async () => {
      const props = createProps();
      renderModal(props);
    
      await waitFor(() => {
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 170..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('"Close" button should call "onHide"', async () => {
      const props = createProps();
      renderModal(props);
    
      await waitFor(() => {
    superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx on lines 228..242

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      await waitFor(() => {
        expect(
          screen.queryByRole('dialog', { name: 'Edit Chart Properties' }),
        ).not.toBeInTheDocument();
      });
    superset-frontend/src/explore/components/controls/ColorSchemeControl/ColorSchemeControl.test.tsx on lines 64..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status