Sign upLogin

airbnb/superset

View on GitHub
Star
superset-frontend/src/views/CRUD/hooks.ts

Summary

Maintainability
F
1 wk
Test Coverage

File hooks.ts has 781 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Major
Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 day to fix

    Function useSingleViewResource has 144 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function useSingleViewResource<D extends object = any>(
  resourceName: string,
  resourceLabel: string, // resourceLabel for translations
  handleErrorMsg: (errorMsg: string) => void,
  path_suffix = '',
    Severity: Major
    Found in superset-frontend/src/views/CRUD/hooks.ts - About 5 hrs to fix

      Function useListViewResource has 128 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function useListViewResource<D extends object = any>(
  resource: string,
  resourceLabel: string, // resourceLabel for translations
  handleErrorMsg: (errorMsg: string) => void,
  infoEnable = true,
      Severity: Major
      Found in superset-frontend/src/views/CRUD/hooks.ts - About 5 hrs to fix

        Function useDatabaseValidation has 124 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function useDatabaseValidation() {
  const [validationErrors, setValidationErrors] = useState<JsonObject | null>(
    null,
  );
  const getValidation = useCallback(
        Severity: Major
        Found in superset-frontend/src/views/CRUD/hooks.ts - About 4 hrs to fix

          Function useImportResource has 117 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function useImportResource(
  resourceName: ImportResourceName,
  resourceLabel: string, // resourceLabel for translations
  handleErrorMsg: (errorMsg: string) => void,
) {
          Severity: Major
          Found in superset-frontend/src/views/CRUD/hooks.ts - About 4 hrs to fix

            Function getValidation has 115 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                (database: Partial<DatabaseObject> | null, onCreate = false) => {
      if (database?.parameters?.ssh) {
        // TODO: /validate_parameters/ and related utils should support ssh tunnel
        setValidationErrors(null);
        return [];
            Severity: Major
            Found in superset-frontend/src/views/CRUD/hooks.ts - About 4 hrs to fix

              Function importResource has 92 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  (
      bundle: File,
      databasePasswords: Record<string, string> = {},
      sshTunnelPasswords: Record<string, string> = {},
      sshTunnelPrivateKey: Record<string, string> = {},
              Severity: Major
              Found in superset-frontend/src/views/CRUD/hooks.ts - About 3 hrs to fix

                Function useListViewResource has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                export function useListViewResource<D extends object = any>(
  resource: string,
  resourceLabel: string, // resourceLabel for translations
  handleErrorMsg: (errorMsg: string) => void,
  infoEnable = true,
                Severity: Minor
                Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function useFavoriteStatus has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function useFavoriteStatus(
  type: 'chart' | 'dashboard' | 'tag',
  ids: Array<string | number>,
  handleErrorMsg: (message: string) => void,
) {
                Severity: Minor
                Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                  Function updateResource has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      (resourceID: number, resource: D, hideToast = false, setLoading = true) => {
      // Set loading state
      if (setLoading) {
        updateState({
          loading: true,
                  Severity: Minor
                  Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                    Function createResource has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        (resource: D, hideToast = false) => {
      // Set loading state
      updateState({
        loading: true,
      });
                    Severity: Minor
                    Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                      Function fetchResource has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          (resourceID: number) => {
      // Set loading state
      updateState({
        loading: true,
      });
                      Severity: Minor
                      Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                        Function useChartEditModal has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export const useChartEditModal = (
  setCharts: (charts: Array<Chart>) => void,
  charts: Array<Chart>,
) => {
  const [sliceCurrentlyEditing, setSliceCurrentlyEditing] =
                        Severity: Minor
                        Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                          Function useImportResource has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function useImportResource(
  resourceName: ImportResourceName,
  resourceLabel: string, // resourceLabel for translations
  handleErrorMsg: (errorMsg: string) => void,
) {
                          Severity: Minor
                          Found in superset-frontend/src/views/CRUD/hooks.ts - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function useListViewResource has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            resource: string,
  resourceLabel: string, // resourceLabel for translations
  handleErrorMsg: (errorMsg: string) => void,
  infoEnable = true,
  defaultCollectionValue: D[] = [],
                          Severity: Major
                          Found in superset-frontend/src/views/CRUD/hooks.ts - About 50 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                                  return obj;
                            Severity: Major
                            Found in superset-frontend/src/views/CRUD/hooks.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                      return {
                          ...obj,
                          error_type,
                          description: message || extra.issue_codes[0]?.message,
                        };
                              Severity: Major
                              Found in superset-frontend/src/views/CRUD/hooks.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                        return {
                          ...obj,
                          error_type,
                          ...Object.assign(
                            {},
                                Severity: Major
                                Found in superset-frontend/src/views/CRUD/hooks.ts - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                  export const copyQueryLink = (
  id: number,
  addDangerToast: (arg0: string) => void,
  addSuccessToast: (arg0: string) => void,
) => {
                                  Severity: Major
                                  Found in superset-frontend/src/views/CRUD/hooks.ts and 1 other location - About 2 hrs to fix
                                  superset-frontend/src/pages/SavedQueryList/index.tsx on lines 236..246

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 91.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                          if (extra.catalog.name) {
                          return {
                            ...obj,
                            error_type,
                            [extra.catalog.idx]: {
                                  Severity: Minor
                                  Found in superset-frontend/src/views/CRUD/hooks.ts and 1 other location - About 35 mins to fix
                                  superset-frontend/src/views/CRUD/hooks.ts on lines 816..824

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 46.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                          if (extra.catalog.url) {
                          return {
                            ...obj,
                            error_type,
                            [extra.catalog.idx]: {
                                  Severity: Minor
                                  Found in superset-frontend/src/views/CRUD/hooks.ts and 1 other location - About 35 mins to fix
                                  superset-frontend/src/views/CRUD/hooks.ts on lines 807..815

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 46.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                    function updateState(update: Partial<ListViewResourceState<D>>) {
    setState(currentState => ({ ...currentState, ...update }));
  }
                                  Severity: Minor
                                  Found in superset-frontend/src/views/CRUD/hooks.ts and 1 other location - About 30 mins to fix
                                  superset-frontend/src/views/CRUD/hooks.ts on lines 241..243

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 45.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                    function updateState(update: Partial<SingleViewResourceState<D>>) {
    setState(currentState => ({ ...currentState, ...update }));
  }
                                  Severity: Minor
                                  Found in superset-frontend/src/views/CRUD/hooks.ts and 1 other location - About 30 mins to fix
                                  superset-frontend/src/views/CRUD/hooks.ts on lines 90..92

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 45.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status